<p><b>@ripcurlx</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3194#discussion_r321110399">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java</a>:</p>
<pre style='color:#555'>> @@ -1208,4 +1216,35 @@ private void stopTimeoutTimer() {
     private BSFormatter getFormatterForMakerFee() {
         return dataModel.isCurrencyForMakerFeeBtc() ? btcFormatter : bsqFormatter;
     }
+
</pre>
<p>On second look, yes it is not really feasible to move everything into the data model. Please move only the calculation part as you suggested to the data model. There is already a block of calculate... methods there. Besides that and the naming of the update method ACK</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3194?email_source=notifications&email_token=AJFFTNTIVJW2KQOZ7B6BYT3QICYBLA5CNFSM4ITGGISKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDXHLVQ#discussion_r321110399">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSSXE3QNSAXPISNEVLQICYBLANCNFSM4ITGGISA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNTALPNX4GMPHBCCVRLQICYBLA5CNFSM4ITGGISKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDXHLVQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3194?email_source=notifications\u0026email_token=AJFFTNTIVJW2KQOZ7B6BYT3QICYBLA5CNFSM4ITGGISKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDXHLVQ#discussion_r321110399",
"url": "https://github.com/bisq-network/bisq/pull/3194?email_source=notifications\u0026email_token=AJFFTNTIVJW2KQOZ7B6BYT3QICYBLA5CNFSM4ITGGISKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDXHLVQ#discussion_r321110399",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>