<p><b>@freimair</b> requested changes on this pull request.</p>
<p>Please only change stuff that actually changes code behavior. It is really cumbersome to check method signatures and whether they changed or not. Your suggestion contains 10+ method headers that have not changed functionally, but all of them are changes. Please revert those unnecessary changes now and in the future. Thanks!</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3212#discussion_r321654067">core/src/main/java/bisq/core/offer/OfferUtil.java</a>:</p>
<pre style='color:#555'>> @@ -116,7 +116,9 @@ public static Coin getMakerFee(boolean isCurrencyForMakerFeeBtc, @Nullable Coin
* @param amount
* @return
*/
- public static boolean isCurrencyForMakerFeeBtc(Preferences preferences, BsqWalletService bsqWalletService, Coin amount) {
+ public static boolean isCurrencyForMakerFeeBtc(Preferences preferences,
+ BsqWalletService bsqWalletService,
+ Coin amount) {
</pre>
<p>please only change stuff that actually changes something. Makes it more cumbersome to review...</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3212#discussion_r321654150">core/src/main/java/bisq/core/offer/OfferUtil.java</a>:</p>
<pre style='color:#555'>> @@ -152,7 +154,9 @@ public static Coin getTakerFee(boolean isCurrencyForTakerFeeBtc, @Nullable Coin
}
}
- public static boolean isCurrencyForTakerFeeBtc(Preferences preferences, BsqWalletService bsqWalletService, Coin amount) {
+ public static boolean isCurrencyForTakerFeeBtc(Preferences preferences,
+ BsqWalletService bsqWalletService,
+ Coin amount) {
</pre>
<p>please only change stuff that actually changes something. Makes it cumbersome to review...</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3212#discussion_r321654366">core/src/main/java/bisq/core/offer/OfferUtil.java</a>:</p>
<pre style='color:#555'>> @@ -306,7 +321,9 @@ static Coin getAdjustedAmount(Coin amount, Price price, long maxTradeLimit, int
}
}
- public static String getFeeWithFiatAmount(Coin makerFeeAsCoin, Optional<Volume> optionalFeeInFiat, BSFormatter formatter) {
+ public static String getFeeWithFiatAmount(Coin makerFeeAsCoin,
+ Optional<Volume> optionalFeeInFiat,
+ BSFormatter formatter) {
</pre>
<p>please only change stuff that actually changes something. Makes it cumbersome to review...</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3212#discussion_r321654509">desktop/src/main/java/bisq/desktop/main/dao/economy/dashboard/BsqDashboardView.java</a>:</p>
<pre style='color:#555'>> private Label marketPriceLabel;
private Coin availableAmount;
-
</pre>
<p>please only change stuff that actually changes something. Makes it more cumbersome to review...</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3212#discussion_r321654538">desktop/src/main/java/bisq/desktop/main/dao/economy/dashboard/BsqDashboardView.java</a>:</p>
<pre style='color:#555'>> private int gridRow = 0;
+
</pre>
<p>please only change stuff that actually changes something. Makes it more cumbersome to review...</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3212#discussion_r321654630">desktop/src/main/java/bisq/desktop/main/dao/economy/dashboard/BsqDashboardView.java</a>:</p>
<pre style='color:#555'>> @@ -122,32 +128,37 @@ private BsqDashboardView(DaoFacade daoFacade,
@Override
public void initialize() {
-
</pre>
<p>please only change stuff that actually changes something. Makes it more cumbersome to review...</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3212#discussion_r321654689">desktop/src/main/java/bisq/desktop/main/dao/economy/dashboard/BsqDashboardView.java</a>:</p>
<pre style='color:#555'>> }
private void createKPIs() {
-
</pre>
<p>please only change stuff that actually changes something. Makes it more cumbersome to review...</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3212#discussion_r321654846">desktop/src/main/java/bisq/desktop/main/dao/economy/dashboard/BsqDashboardView.java</a>:</p>
<pre style='color:#555'>> }
- private void updateBSQPriceData() {
+ private void updateBsqPriceData() {
</pre>
<p>please only change stuff that actually changes something. Makes it really cumbersome to review...</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3212#discussion_r321655817">desktop/src/main/java/bisq/desktop/util/GUIUtil.java</a>:</p>
<pre style='color:#555'>> @@ -204,8 +214,12 @@ public static void exportAccounts(ArrayList<PaymentAccount> accounts, String fil
}
}
- public static void importAccounts(User user, String fileName, Preferences preferences, Stage stage,
- PersistenceProtoResolver persistenceProtoResolver, CorruptedDatabaseFilesHandler corruptedDatabaseFilesHandler) {
+ public static void importAccounts(User user,
+ String fileName,
+ Preferences preferences,
+ Stage stage,
+ PersistenceProtoResolver persistenceProtoResolver,
+ CorruptedDatabaseFilesHandler corruptedDatabaseFilesHandler) {
</pre>
<p>please only change stuff that actually changes something. I am stopping at this point because that is too much.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3212#discussion_r321656365">desktop/src/main/java/bisq/desktop/util/GUIUtil.java</a>:</p>
<pre style='color:#555'>> @@ -189,8 +195,12 @@ public static void showFeeInfoBeforeExecute(Runnable runnable) {
}
}
- public static void exportAccounts(ArrayList<PaymentAccount> accounts, String fileName,
- Preferences preferences, Stage stage, PersistenceProtoResolver persistenceProtoResolver, CorruptedDatabaseFilesHandler corruptedDatabaseFilesHandler) {
+ public static void exportAccounts(ArrayList<PaymentAccount> accounts,
+ String fileName,
+ Preferences preferences,
+ Stage stage,
+ PersistenceProtoResolver persistenceProtoResolver,
+ CorruptedDatabaseFilesHandler corruptedDatabaseFilesHandler) {
</pre>
<p>please only change stuff that actually changes something. Makes it REALLY cumbersome to review...</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3212?email_source=notifications&email_token=AJFFTNVFXZ542UCHM5OULSTQIIQTZA5CNFSM4IUELKQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD4QSSI#pullrequestreview-284756297">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNT4RC5KKAA42LIH5DLQIIQTZANCNFSM4IUELKQA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNTXN2DJZZ4SQGX6FYLQIIQTZA5CNFSM4IUELKQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD4QSSI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3212?email_source=notifications\u0026email_token=AJFFTNVFXZ542UCHM5OULSTQIIQTZA5CNFSM4IUELKQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD4QSSI#pullrequestreview-284756297",
"url": "https://github.com/bisq-network/bisq/pull/3212?email_source=notifications\u0026email_token=AJFFTNVFXZ542UCHM5OULSTQIIQTZA5CNFSM4IUELKQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD4QSSI#pullrequestreview-284756297",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>