<p><b>@chimp1984</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3221#discussion_r321987498">common/src/main/proto/pb.proto</a>:</p>
<pre style='color:#555'>> @@ -44,6 +44,7 @@ message NetworkEnvelope {
 
         OpenNewDisputeMessage open_new_dispute_message = 22;
         PeerOpenedDisputeMessage peer_opened_dispute_message = 23;
+        // ChatMessage in java class. We cannot rename protobuf definition because it would break backward compatibility
</pre>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1999" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/christophsturm">@christophsturm</a> Enums must not be renamed as we use the name for resolving.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3221?email_source=notifications&email_token=AJFFTNQ52ZHBFQQSET6N6ELQIRB4LA5CNFSM4IUNIQ7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD73BOI#discussion_r321987498">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVNIN5EINC3BSBKTNTQIRB4LANCNFSM4IUNIQ7A">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNXJJ2WV37IAP34A4E3QIRB4LA5CNFSM4IUNIQ7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD73BOI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3221?email_source=notifications\u0026email_token=AJFFTNQ52ZHBFQQSET6N6ELQIRB4LA5CNFSM4IUNIQ7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD73BOI#discussion_r321987498",
"url": "https://github.com/bisq-network/bisq/pull/3221?email_source=notifications\u0026email_token=AJFFTNQ52ZHBFQQSET6N6ELQIRB4LA5CNFSM4IUNIQ7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD73BOI#discussion_r321987498",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>