<p><b>@chimp1984</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3221#discussion_r321973619">common/src/main/proto/pb.proto</a>:</p>
<pre style='color:#555'>> @@ -44,6 +44,7 @@ message NetworkEnvelope {
 
         OpenNewDisputeMessage open_new_dispute_message = 22;
         PeerOpenedDisputeMessage peer_opened_dispute_message = 23;
+        // ChatMessage in java class. We cannot rename protobuf definition because it would break backward compatibility
</pre>
<p>I just tested it. With pure network messages the class and field name are irrelevant, so yes in that case we can rename it. I will make a commit later.<br>
Though we have to take care to not do that on protobuf objects which are peristed (or used in both network and peristence context) as locally stored data would break then.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3221?email_source=notifications&email_token=AJFFTNWJ62TYARS7VRRDVSTQIPDRPA5CNFSM4IUNIQ7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD7XIDI#discussion_r321973619">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWDS4J2K5Q44HMEF5TQIPDRPANCNFSM4IUNIQ7A">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNV6IPKE5UPKIM35SLDQIPDRPA5CNFSM4IUNIQ7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD7XIDI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3221?email_source=notifications\u0026email_token=AJFFTNWJ62TYARS7VRRDVSTQIPDRPA5CNFSM4IUNIQ7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD7XIDI#discussion_r321973619",
"url": "https://github.com/bisq-network/bisq/pull/3221?email_source=notifications\u0026email_token=AJFFTNWJ62TYARS7VRRDVSTQIPDRPA5CNFSM4IUNIQ7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD7XIDI#discussion_r321973619",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>