<p><b>@ripcurlx</b> requested changes on this pull request.</p>

<p>NACK - Although it wasn't up for review - here some minor change suggestions. <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=232186" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/wiz">@wiz</a> Do you plan to open this PR for public review soon?</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3225#discussion_r322102822">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -2804,6 +2804,17 @@ payment.f2f.info.openURL=Open web page
 payment.f2f.offerbook.tooltip.countryAndCity=Country and city: {0} / {1}
 payment.f2f.offerbook.tooltip.extra=Additional information: {0}
 
+# Japan Bank Transfer
+payment.japan.bank=Bank or Financial Institution
+payment.japan.bank.select=Search for Financial Institution
+payment.japan.bank.code=Bank Code
</pre>
<p>To prevent unnecessary translations you could use <code>payment.bankCode</code> instead.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3225#discussion_r322102956">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -2804,6 +2804,17 @@ payment.f2f.info.openURL=Open web page
 payment.f2f.offerbook.tooltip.countryAndCity=Country and city: {0} / {1}
 payment.f2f.offerbook.tooltip.extra=Additional information: {0}
 
+# Japan Bank Transfer
+payment.japan.bank=Bank or Financial Institution
+payment.japan.bank.select=Search for Financial Institution
+payment.japan.bank.code=Bank Code
+payment.japan.bank.name=Bank Name
</pre>
<p>To prevent unnecessary translations you could use <code>payment.bank.name</code> instead.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3225#discussion_r322103421">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -2804,6 +2804,17 @@ payment.f2f.info.openURL=Open web page
 payment.f2f.offerbook.tooltip.countryAndCity=Country and city: {0} / {1}
 payment.f2f.offerbook.tooltip.extra=Additional information: {0}
 
+# Japan Bank Transfer
+payment.japan.bank=Bank or Financial Institution
+payment.japan.bank.select=Search for Financial Institution
+payment.japan.bank.code=Bank Code
+payment.japan.bank.name=Bank Name
+payment.japan.bank.branch.code=Branch Code
+payment.japan.bank.branch.name=Branch Name
+payment.japan.bank.account.number=Account Number
</pre>
<p>To prevent unnecessary translations you could use <code>payment.account.no</code> instead.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3225#discussion_r322103684">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -2804,6 +2804,17 @@ payment.f2f.info.openURL=Open web page
 payment.f2f.offerbook.tooltip.countryAndCity=Country and city: {0} / {1}
 payment.f2f.offerbook.tooltip.extra=Additional information: {0}
 
+# Japan Bank Transfer
+payment.japan.bank=Bank or Financial Institution
+payment.japan.bank.select=Search for Financial Institution
+payment.japan.bank.code=Bank Code
+payment.japan.bank.name=Bank Name
+payment.japan.bank.branch.code=Branch Code
+payment.japan.bank.branch.name=Branch Name
+payment.japan.bank.account.number=Account Number
+payment.japan.bank.account.name=Account Name
</pre>
<p>To prevent unnecessary translations you could use <code>payment.account.name</code> instead.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3225#discussion_r322103892">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -2804,6 +2804,17 @@ payment.f2f.info.openURL=Open web page
 payment.f2f.offerbook.tooltip.countryAndCity=Country and city: {0} / {1}
 payment.f2f.offerbook.tooltip.extra=Additional information: {0}
 
+# Japan Bank Transfer
+payment.japan.bank=Bank or Financial Institution
+payment.japan.bank.select=Search for Financial Institution
+payment.japan.bank.code=Bank Code
+payment.japan.bank.name=Bank Name
+payment.japan.bank.branch.code=Branch Code
+payment.japan.bank.branch.name=Branch Name
+payment.japan.bank.account.number=Account Number
+payment.japan.bank.account.name=Account Name
+payment.japan.bank.account.type=Account Type
+payment.japan.bank.account.type.select=Account Type
</pre>
<p>To prevent unnecessary translations you could use <code>payment.select.account</code> instead.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3225#discussion_r322104088">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -2804,6 +2804,17 @@ payment.f2f.info.openURL=Open web page
 payment.f2f.offerbook.tooltip.countryAndCity=Country and city: {0} / {1}
 payment.f2f.offerbook.tooltip.extra=Additional information: {0}
 
+# Japan Bank Transfer
+payment.japan.bank=Bank or Financial Institution
+payment.japan.bank.select=Search for Financial Institution
+payment.japan.bank.code=Bank Code
+payment.japan.bank.name=Bank Name
+payment.japan.bank.branch.code=Branch Code
+payment.japan.bank.branch.name=Branch Name
+payment.japan.bank.account.number=Account Number
+payment.japan.bank.account.name=Account Name
+payment.japan.bank.account.type=Account Type
</pre>
<p>To prevent unnecessary translations you could use <code>payment.accountType</code> instead.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3225#discussion_r322104454">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -2804,6 +2804,17 @@ payment.f2f.info.openURL=Open web page
 payment.f2f.offerbook.tooltip.countryAndCity=Country and city: {0} / {1}
 payment.f2f.offerbook.tooltip.extra=Additional information: {0}
 
+# Japan Bank Transfer
+payment.japan.bank=Bank or Financial Institution
+payment.japan.bank.select=Search for Financial Institution
+payment.japan.bank.code=Bank Code
+payment.japan.bank.name=Bank Name
+payment.japan.bank.branch.code=Branch Code
</pre>
<p>We do have a <code>payment.branchNr</code> -> Branch no., but I'm not sure if it is the perfect replacement in that case.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3225?email_source=notifications&email_token=AJFFTNR6MWCOFSG47MC4QEDQIX6CHA5CNFSM4IUSCO72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEA4HCA#pullrequestreview-285328264">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWQDPQZV3W4OWQO5QDQIX6CHANCNFSM4IUSCO7Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNSNMJIMFWFR25UXW6TQIX6CHA5CNFSM4IUSCO72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEA4HCA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3225?email_source=notifications\u0026email_token=AJFFTNR6MWCOFSG47MC4QEDQIX6CHA5CNFSM4IUSCO72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEA4HCA#pullrequestreview-285328264",
"url": "https://github.com/bisq-network/bisq/pull/3225?email_source=notifications\u0026email_token=AJFFTNR6MWCOFSG47MC4QEDQIX6CHA5CNFSM4IUSCO72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEA4HCA#pullrequestreview-285328264",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>