<p>Thanks a lot for attempting this code refactoring!</p>
<p>I cannot say for actual reviewers (ripcurlx, sqrrm, freimar, ManfredKarrer) but here are my 5 cents. Context: I am a new contributor myself so please don't put to much weight into my comments.</p>
<ol>
<li>
<p>The "Optimize Imports" commit is huge and serious enough for being a PR on its own. Whether this will be welcome by other developers I don't know. Please seek advice on #dev channel. Personally I would very much welcome this (but first we need to make sure import optimization feature is stable across IntelliJ installations).</p>
</li>
<li>
<p>The remaining changes should be probably split into smaller PR-s that are easy for reviewers and do feel safe. Yes, that may be a pain from the productivity point of view. Being "reviewer friendly" is a priority though.</p>
</li>
</ol>
<p>Hope this helps!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3230?email_source=notifications&email_token=AJFFTNT3XEO46MFB2IDRLDTQI6M23A5CNFSM4IUY7GI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6LBJII#issuecomment-529929377">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSQJUH5RLY7XED7A6DQI6M23ANCNFSM4IUY7GIQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNWESW7KUOAIVRMDP33QI6M23A5CNFSM4IUY7GI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6LBJII.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3230?email_source=notifications\u0026email_token=AJFFTNT3XEO46MFB2IDRLDTQI6M23A5CNFSM4IUY7GI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6LBJII#issuecomment-529929377",
"url": "https://github.com/bisq-network/bisq/pull/3230?email_source=notifications\u0026email_token=AJFFTNT3XEO46MFB2IDRLDTQI6M23A5CNFSM4IUY7GI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6LBJII#issuecomment-529929377",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>