<p>While making myself familiar with the code and thinking about improvements I kept seeing complexities connected to the <a href="">BSFormatter</a> class.</p>
<p>The code base is quite tangled up and that class is one of the places that contributes because:</p>
<ul>
<li>it is bucket class with many many unrelated functions</li>
<li>it has a <em>huge</em> public interface even though most functions don't depend on instance state</li>
<li>it depends on globals</li>
<li>it is depended on by many classes</li>
<li>it is part of a type hierarchy</li>
</ul>
<p>This led me to refactor it out of existence. The final state of the code is <a href="https://github.com/bisq-network/bisq/pull/3230" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/3230/hovercard">here</a> but it is too much to review and merge in 1 step.<br>
To get the code changes in I can break it down into 5-6 trivial commits / PRs, but don't want to do this work unless other ppl agree that removing this class makes sense.<br>
Please give <g-emoji class="g-emoji" alias="+1" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f44d.png">👍</g-emoji> or <g-emoji class="g-emoji" alias="-1" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f44e.png">👎</g-emoji> as feedback on wether I should go ahead. Perhaps I am the only one who has seen these issues, or they aren't hurting anyone and the code can stay as is. In that case I don't want to make the effort.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/3240?email_source=notifications&email_token=AJFFTNTS3DAFHZ3UPVWGZPTQJCBQLA5CNFSM4IVPR4N2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKTZQ7A">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVTZI7YACDVIIQG2W3QJCBQLANCNFSM4IVPR4NQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNXSGMIOBMZ25D32XTDQJCBQLA5CNFSM4IVPR4N2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKTZQ7A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/3240?email_source=notifications\u0026email_token=AJFFTNTS3DAFHZ3UPVWGZPTQJCBQLA5CNFSM4IVPR4N2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKTZQ7A",
"url": "https://github.com/bisq-network/bisq/issues/3240?email_source=notifications\u0026email_token=AJFFTNTS3DAFHZ3UPVWGZPTQJCBQLA5CNFSM4IVPR4N2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKTZQ7A",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>