<p>Making these functions static is a preparation for extraction.</p>
<p>Reducing the public interface of the BSFormatter instances reduces coupling and enables moving these functions to places where it makes more sense for them to live.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/3239'>https://github.com/bisq-network/bisq/pull/3239</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Make stateless BSFormatter functions static and remove dead code</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-0">.idea/codeStyles/codeStyleConfig.xml</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-1">core/src/main/java/bisq/core/app/WalletAppSetup.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-2">core/src/main/java/bisq/core/dao/presentation/DaoUtil.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-3">core/src/main/java/bisq/core/dao/state/DaoStateService.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-4">core/src/main/java/bisq/core/notifications/alerts/market/MarketAlerts.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-5">core/src/main/java/bisq/core/notifications/alerts/price/PriceAlert.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-6">core/src/main/java/bisq/core/util/BSFormatter.java</a>
    (148)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-7">desktop/src/main/java/bisq/desktop/components/PeerInfoIcon.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-8">desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-9">desktop/src/main/java/bisq/desktop/main/Chat/Chat.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-10">desktop/src/main/java/bisq/desktop/main/MainViewModel.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-11">desktop/src/main/java/bisq/desktop/main/account/content/notifications/ManageMarketAlertsWindow.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-12">desktop/src/main/java/bisq/desktop/main/account/content/notifications/MobileNotificationsView.java</a>
    (20)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-13">desktop/src/main/java/bisq/desktop/main/dao/bonding/BondingViewUtils.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-14">desktop/src/main/java/bisq/desktop/main/dao/bonding/bonds/BondListItem.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-15">desktop/src/main/java/bisq/desktop/main/dao/bonding/reputation/MyReputationListItem.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-16">desktop/src/main/java/bisq/desktop/main/dao/bonding/roles/RoleDetailsWindow.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-17">desktop/src/main/java/bisq/desktop/main/dao/burnbsq/proofofburn/MyProofOfBurnListItem.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-18">desktop/src/main/java/bisq/desktop/main/dao/burnbsq/proofofburn/ProofOfBurnListItem.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-19">desktop/src/main/java/bisq/desktop/main/dao/governance/proposals/ProposalsView.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-20">desktop/src/main/java/bisq/desktop/main/dao/governance/result/VoteResultView.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-21">desktop/src/main/java/bisq/desktop/main/dao/wallet/tx/BsqTxView.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-22">desktop/src/main/java/bisq/desktop/main/disputes/trader/TraderDisputeView.java</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-23">desktop/src/main/java/bisq/desktop/main/funds/locked/LockedView.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-24">desktop/src/main/java/bisq/desktop/main/funds/reserved/ReservedView.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-25">desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsListItem.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-26">desktop/src/main/java/bisq/desktop/main/market/MarketView.java</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-27">desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-28">desktop/src/main/java/bisq/desktop/main/market/spread/SpreadViewModel.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-29">desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-30">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-31">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java</a>
    (30)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-32">desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-33">desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-34">desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferView.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-35">desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-36">desktop/src/main/java/bisq/desktop/main/overlays/windows/ContractWindow.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-37">desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-38">desktop/src/main/java/bisq/desktop/main/overlays/windows/OfferDetailsWindow.java</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-39">desktop/src/main/java/bisq/desktop/main/overlays/windows/ProposalResultsWindow.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-40">desktop/src/main/java/bisq/desktop/main/overlays/windows/TradeDetailsWindow.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-41">desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-42">desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferViewModel.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-43">desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesViewModel.java</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-44">desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersViewModel.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-45">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-46">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-47">desktop/src/main/java/bisq/desktop/main/presentation/MarketPricePresentation.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-48">desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-49">desktop/src/main/java/bisq/desktop/main/settings/network/P2pNetworkListItem.java</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-50">desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-51">desktop/src/main/java/bisq/desktop/util/GUIUtil.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-52">desktop/src/main/java/bisq/desktop/util/validation/SecurityDepositValidator.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3239/files#diff-53">desktop/src/test/java/bisq/desktop/util/BSFormatterTest.java</a>
    (48)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/3239.patch'>https://github.com/bisq-network/bisq/pull/3239.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/3239.diff'>https://github.com/bisq-network/bisq/pull/3239.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3239?email_source=notifications&email_token=AJFFTNWQ32K5NKA2J7UEKYDQJBTNTA5CNFSM4IVO5HX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKTLNWA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWDFHCM6O4LANPMLOTQJBTNTANCNFSM4IVO5HXQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNWF53OPRL6GYHBLDS3QJBTNTA5CNFSM4IVO5HX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKTLNWA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3239?email_source=notifications\u0026email_token=AJFFTNWQ32K5NKA2J7UEKYDQJBTNTA5CNFSM4IVO5HX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKTLNWA",
"url": "https://github.com/bisq-network/bisq/pull/3239?email_source=notifications\u0026email_token=AJFFTNWQ32K5NKA2J7UEKYDQJBTNTA5CNFSM4IVO5HX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKTLNWA",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>