<p>While testing different variations of upgrade scenarios, I encountered a NullPointer exception. This may not be directly related to mediation (I have yet to confirm), but was encountered while testing it.</p>
<p><strong>Preconditions</strong></p>
<ul>
<li>Offers of old clients permitted, mediation deactivated:<br>
OfferRestrictions.REQUIRE_UPDATE_DATE = 25.9<br>
MediationManager.MEDIATION_ACTIVATED_DATE = 30.9</li>
<li>Alice and Bob running old version (v1.1.5).</li>
</ul>
<p><strong>Steps to reproduce</strong></p>
<ul>
<li>Bob takes offer, BTC seller as taker.</li>
<li>Alice confirms payment started.</li>
<li>Alice updates and starts her client.</li>
</ul>
<p><strong>Result</strong><br>
Alice encounters the following NPE on starting her client.<br>
Notes:</p>
<ul>
<li>Did not encounter the error upon restarting the client subsequent times.</li>
<li>Same error is encountered when Bob updates and starts his client.</li>
</ul>
<pre><code>Sep-10 23:42:31.753 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: Uncaught Exception from thread JavaFX Application Thread
Sep-10 23:42:31.754 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: throwableMessage= null
Sep-10 23:42:31.754 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: throwableClass= class java.lang.NullPointerException
Sep-10 23:42:31.759 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: Stack trace:
java.lang.NullPointerException
        at bisq.core.btc.wallet.WalletService.getTransaction(WalletService.java:610)
        at bisq.core.btc.wallet.WalletService.getTransaction(WalletService.java:615)
        at bisq.core.trade.Trade.getDepositTx(Trade.java:607)
        at bisq.desktop.main.portfolio.pendingtrades.PendingTradesDataModel.doSelectItem(PendingTradesDataModel.java:403)
        at bisq.desktop.main.portfolio.pendingtrades.PendingTradesDataModel.selectBestItem(PendingTradesDataModel.java:379)
        at bisq.desktop.main.portfolio.pendingtrades.PendingTradesDataModel.onListChanged(PendingTradesDataModel.java:374)
        at bisq.desktop.main.portfolio.pendingtrades.PendingTradesDataModel.activate(PendingTradesDataModel.java:151)
        at bisq.desktop.common.model.ActivatableDataModel._activate(ActivatableDataModel.java:28)
        at bisq.desktop.common.model.ActivatableWithDataModel._activate(ActivatableWithDataModel.java:28)
        at bisq.desktop.common.view.ActivatableViewAndModel.lambda$prepareInitialize$0(ActivatableViewAndModel.java:42)
        at com.sun.javafx.binding.ExpressionHelper$SingleChange.fireValueChangedEvent(ExpressionHelper.java:181)
        at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)
        at javafx.beans.property.ReadOnlyObjectPropertyBase.fireValueChangedEvent(ReadOnlyObjectPropertyBase.java:74)
        at javafx.beans.property.ReadOnlyObjectWrapper.fireValueChangedEvent(ReadOnlyObjectWrapper.java:102)
        at javafx.scene.Node$ReadOnlyObjectWrapperManualFire.fireSuperValueChangedEvent(Node.java:1054)
        at javafx.scene.Node.invalidatedScenes(Node.java:1114)
        at javafx.scene.Node.setScenes(Node.java:1152)
        at javafx.scene.Parent.scenesChanged(Parent.java:769)
        at javafx.scene.Node.invalidatedScenes(Node.java:1076)
        at javafx.scene.Node.setScenes(Node.java:1152)
        at javafx.scene.Parent$2.onChanged(Parent.java:369)
        at com.sun.javafx.collections.TrackableObservableList.lambda$new$0(TrackableObservableList.java:45)
        at com.sun.javafx.collections.ListListenerHelper$Generic.fireValueChangedEvent(ListListenerHelper.java:329)
        at com.sun.javafx.collections.ListListenerHelper.fireValueChangedEvent(ListListenerHelper.java:73)
        at javafx.collections.ObservableListBase.fireChange(ObservableListBase.java:233)
        at javafx.collections.ListChangeBuilder.commit(ListChangeBuilder.java:482)
        at javafx.collections.ListChangeBuilder.endChange(ListChangeBuilder.java:541)
        at javafx.collections.ObservableListBase.endChange(ObservableListBase.java:205)
        at javafx.collections.ModifiableObservableListBase.add(ModifiableObservableListBase.java:155)
        at com.sun.javafx.collections.VetoableListDecorator.add(VetoableListDecorator.java:320)
        at com.jfoenix.skins.JFXTabPaneSkin.addTabContentHolder(JFXTabPaneSkin.java:228)
        at com.jfoenix.skins.JFXTabPaneSkin.<init>(JFXTabPaneSkin.java:100)
        at com.jfoenix.controls.JFXTabPane.createDefaultSkin(JFXTabPane.java:67)
        at javafx.scene.control.Control.doProcessCSS(Control.java:897)
        at javafx.scene.control.Control.access$000(Control.java:83)
        at javafx.scene.control.Control$1.doProcessCSS(Control.java:89)
        at com.sun.javafx.scene.control.ControlHelper.processCSSImpl(ControlHelper.java:67)
        at com.sun.javafx.scene.NodeHelper.processCSS(NodeHelper.java:145)
        at javafx.scene.Node.processCSS(Node.java:9529)
        at javafx.scene.Node.processCSS(Node.java:9522)
        at javafx.scene.Node.processCSS(Node.java:9522)
        at javafx.scene.Node.processCSS(Node.java:9522)
        at javafx.scene.Node.processCSS(Node.java:9522)
        at javafx.scene.Scene.doCSSPass(Scene.java:569)
        at javafx.scene.Scene.access$3400(Scene.java:172)
        at javafx.scene.Scene$ScenePulseListener.pulse(Scene.java:2477)
        at com.sun.javafx.tk.Toolkit.lambda$runPulse$2(Toolkit.java:412)
        at java.base/java.security.AccessController.doPrivileged(Native Method)
        at com.sun.javafx.tk.Toolkit.runPulse(Toolkit.java:411)
        at com.sun.javafx.tk.Toolkit.firePulse(Toolkit.java:438)
        at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:519)
        at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:499)
        at com.sun.javafx.tk.quantum.QuantumToolkit.pulseFromQueue(QuantumToolkit.java:492)
        at com.sun.javafx.tk.quantum.QuantumToolkit.lambda$runToolkit$11(QuantumToolkit.java:320)
        at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
        at com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
        at com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
        at java.base/java.lang.Thread.run(Thread.java:844)
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3221?email_source=notifications&email_token=AJFFTNSHYY6RCIEZ32NBPYLQJEURLA5CNFSM4IUNIQ7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6PJPPI#issuecomment-530487229">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSLB6R3FJXS747YREDQJEURLANCNFSM4IUNIQ7A">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNSI2AC3AEJR6H5ERF3QJEURLA5CNFSM4IUNIQ7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6PJPPI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3221?email_source=notifications\u0026email_token=AJFFTNSHYY6RCIEZ32NBPYLQJEURLA5CNFSM4IUNIQ7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6PJPPI#issuecomment-530487229",
"url": "https://github.com/bisq-network/bisq/pull/3221?email_source=notifications\u0026email_token=AJFFTNSHYY6RCIEZ32NBPYLQJEURLA5CNFSM4IUNIQ7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6PJPPI#issuecomment-530487229",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>