<blockquote>
<p>making the method static is only useful if you really move the method. so to see if it makes sense the move needs to be in the same pr.</p>
</blockquote>
<p>I disagree. Reducing the public api of the BSFormatter <em>instance</em> is useful in itself as it makes it possible to see in the calling code if there is a dependency on hidden state or the function is stateless.</p>
<p>Either way I will open another PR with the first move included.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3239?email_source=notifications&email_token=AJFFTNSZ3FKUHNVTBZ7WJF3QJC3KJA5CNFSM4IVO5HX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6N4F3I#issuecomment-530301677">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNV5SEAF7BTYSYJQXLTQJC3KJANCNFSM4IVO5HXQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNVBWABO4VM36YYH66LQJC3KJA5CNFSM4IVO5HX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6N4F3I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3239?email_source=notifications\u0026email_token=AJFFTNSZ3FKUHNVTBZ7WJF3QJC3KJA5CNFSM4IVO5HX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6N4F3I#issuecomment-530301677",
"url": "https://github.com/bisq-network/bisq/pull/3239?email_source=notifications\u0026email_token=AJFFTNSZ3FKUHNVTBZ7WJF3QJC3KJA5CNFSM4IVO5HX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6N4F3I#issuecomment-530301677",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>