<p>Part 3 of my ongoing refactoring to remove BSFormatter.</p>
<p>This is the last refactoring that deals with method extraction. Next step will be to extract the CoinFormatter interface to deal with the polymorphism between BsFormatter and BsqFormatter.</p>
<p>Tracking issue: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="492031038" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3240" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/3240/hovercard" href="https://github.com/bisq-network/bisq/issues/3240">#3240</a></p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/3253'>https://github.com/bisq-network/bisq/pull/3253</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Extract FormattingUtils from BSFormatter</li>
<li>Remove dead Code from BSFormatter</li>
<li>Move Currency related helpers out of BSFormatter to CurrencyUtils</li>
<li>Move functions that only have 1 call-site out of BSFormatter</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-0">core/src/main/java/bisq/core/app/WalletAppSetup.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-1">core/src/main/java/bisq/core/dao/presentation/DaoUtil.java</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-2">core/src/main/java/bisq/core/locale/CurrencyUtil.java</a>
(25)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-3">core/src/main/java/bisq/core/notifications/alerts/market/MarketAlerts.java</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-4">core/src/main/java/bisq/core/notifications/alerts/price/PriceAlert.java</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-5">core/src/main/java/bisq/core/util/BSFormatter.java</a>
(378)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-6">core/src/main/java/bisq/core/util/BsqFormatter.java</a>
(16)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-7">core/src/main/java/bisq/core/util/FormattingUtils.java</a>
(280)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-8">core/src/main/java/bisq/core/util/ParsingUtils.java</a>
(2)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-9">core/src/test/java/bisq/core/util/FormattingUtilsTest.java</a>
(69)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-10">desktop/src/main/java/bisq/desktop/components/ColoredDecimalPlacesWithZerosText.java</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-11">desktop/src/main/java/bisq/desktop/main/account/content/notifications/ManageMarketAlertsWindow.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-12">desktop/src/main/java/bisq/desktop/main/account/content/notifications/MobileNotificationsView.java</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-13">desktop/src/main/java/bisq/desktop/main/dao/bonding/BondingViewUtils.java</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-14">desktop/src/main/java/bisq/desktop/main/dao/economy/dashboard/BsqDashboardView.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-15">desktop/src/main/java/bisq/desktop/main/dao/governance/result/CycleListItem.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-16">desktop/src/main/java/bisq/desktop/main/disputes/trader/TraderDisputeView.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-17">desktop/src/main/java/bisq/desktop/main/market/MarketView.java</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-18">desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-19">desktop/src/main/java/bisq/desktop/main/market/spread/SpreadViewModel.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-20">desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java</a>
(15)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-21">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-22">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java</a>
(25)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-23">desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-24">desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-25">desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferView.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-26">desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-27">desktop/src/main/java/bisq/desktop/main/overlays/windows/ContractWindow.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-28">desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-29">desktop/src/main/java/bisq/desktop/main/overlays/windows/OfferDetailsWindow.java</a>
(18)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-30">desktop/src/main/java/bisq/desktop/main/overlays/windows/TradeDetailsWindow.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-31">desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-32">desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferViewModel.java</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-33">desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesViewModel.java</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-34">desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersViewModel.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-35">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-36">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java</a>
(32)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-37">desktop/src/main/java/bisq/desktop/main/presentation/MarketPricePresentation.java</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-38">desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.java</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-39">desktop/src/main/java/bisq/desktop/main/settings/network/P2pNetworkListItem.java</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-40">desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-41">desktop/src/main/java/bisq/desktop/util/DisplayUtils.java</a>
(25)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-42">desktop/src/main/java/bisq/desktop/util/GUIUtil.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-43">desktop/src/main/java/bisq/desktop/util/validation/SecurityDepositValidator.java</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3253/files#diff-44">desktop/src/test/java/bisq/desktop/util/BSFormatterTest.java</a>
(41)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/3253.patch'>https://github.com/bisq-network/bisq/pull/3253.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/3253.diff'>https://github.com/bisq-network/bisq/pull/3253.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3253?email_source=notifications&email_token=AJFFTNXVGYBUC636DXWOL33QJM4W7A5CNFSM4IWMZGW2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HLFGTZA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNX3MQ3C77EJLMAZUXTQJM4W7ANCNFSM4IWMZGWQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNS3YS4R3OLHBXHIYY3QJM4W7A5CNFSM4IWMZGW2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HLFGTZA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3253?email_source=notifications\u0026email_token=AJFFTNXVGYBUC636DXWOL33QJM4W7A5CNFSM4IWMZGW2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HLFGTZA",
"url": "https://github.com/bisq-network/bisq/pull/3253?email_source=notifications\u0026email_token=AJFFTNXVGYBUC636DXWOL33QJM4W7A5CNFSM4IWMZGW2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HLFGTZA",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>