<p>The reactfx was a 0.33MB dependency / 238 Java source files.</p>
<p>We only used it for FxTimer helper and to measure FPS in development mode.</p>
<p>The small FxTimer class got copied over into the project, so there is no change in semantics.</p>
<p>The FPS measurement got replaced w/ com.sun.javafx.perf.PerformanceTracker, an internal but long stable part of JavaFx. This is probably not a problem, because it only concerns a rarely used, developer feature.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/3279'>https://github.com/bisq-network/bisq/pull/3279</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Remove reactfx dependency</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3279/files#diff-0">build.gradle</a>
    (2)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3279/files#diff-1">common/src/main/java/bisq/common/reactfx/FxTimer.java</a>
    (104)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3279/files#diff-2">common/src/main/java/bisq/common/reactfx/README.md</a>
    (6)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3279/files#diff-3">common/src/main/java/bisq/common/reactfx/Timer.java</a>
    (66)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3279/files#diff-4">desktop/src/main/java/bisq/desktop/app/BisqApp.java</a>
    (18)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3279/files#diff-5">desktop/src/main/java/bisq/desktop/common/UITimer.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3279/files#diff-6">gradle/witness/gradle-witness.gradle</a>
    (1)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/3279.patch'>https://github.com/bisq-network/bisq/pull/3279.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/3279.diff'>https://github.com/bisq-network/bisq/pull/3279.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3279?email_source=notifications&email_token=AJFFTNSAPQU3J2MIRQTP36TQKDN7NA5CNFSM4IXQHRDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HL3RWRA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWFEFJIHEKRKNVSOWTQKDN7NANCNFSM4IXQHRDA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNSTWPL27YKNLRBDWETQKDN7NA5CNFSM4IXQHRDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HL3RWRA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3279?email_source=notifications\u0026email_token=AJFFTNSAPQU3J2MIRQTP36TQKDN7NA5CNFSM4IXQHRDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HL3RWRA",
"url": "https://github.com/bisq-network/bisq/pull/3279?email_source=notifications\u0026email_token=AJFFTNSAPQU3J2MIRQTP36TQKDN7NA5CNFSM4IXQHRDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HL3RWRA",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>