<blockquote>
<p>Does it make sense to include the library code as a git submodule?</p>
</blockquote>
<p>No, that's not how PRs work :) But is the code really that huge? (honestly asking, I have no idea)</p>
<blockquote>
<p>keep a link to the source repository for updates.</p>
</blockquote>
<p>You should do future PRs to update source for bug fixes or new features. Everything needs to be reviewed and have consensus by the community.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3275?email_source=notifications&email_token=AJFFTNTRAEK2JBB23V7274DQKFTCJA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66GZ6Q#issuecomment-532442362">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNX43ZNHLKWZ35EPASTQKFTCJANCNFSM4IXG65PA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNXUII3HR25B5UGVJ5TQKFTCJA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66GZ6Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3275?email_source=notifications\u0026email_token=AJFFTNTRAEK2JBB23V7274DQKFTCJA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66GZ6Q#issuecomment-532442362",
"url": "https://github.com/bisq-network/bisq/pull/3275?email_source=notifications\u0026email_token=AJFFTNTRAEK2JBB23V7274DQKFTCJA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66GZ6Q#issuecomment-532442362",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>