I understand your concern perfectly. With that in mind, it will not make a<br>
difference if the code is included directly (which is the quick fix I am<br>
considering right now).<br>
<br>
On Tue, Sep 17, 2019 at 11:18 PM wiz <notifications@github.com> wrote:<br>
<br>
> Yeah, just to give you an idea, we had a dev call yesterday about adding<br>
> API into Bisq. There has been consensus to add an API into Bisq for 2<br>
> years, but the PR has still not been approved because it wants to add jar<br>
> deps. I made the argument that a single jar dep could be accepted if it's<br>
> published by a large trustworthy organization such as Google (in the case<br>
> of protobuf) or Square (in the case of their http jar). But you guys<br>
> publishing your own jar could be interpreted as an attempt to sneak code<br>
> into Bisq, so please understand why this needs to be included as part of<br>
> the PR (and then still might be rejected for other reasons)<br>
><br>
> —<br>
> You are receiving this because you were mentioned.<br>
> Reply to this email directly, view it on GitHub<br>
> <https://github.com/bisq-network/bisq/pull/3275?email_source=notifications&email_token=AE2MWRZXFZFPQQRPLNMWHHLQKFJSRA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66CKAI#issuecomment-532423937>,<br>
> or mute the thread<br>
> <https://github.com/notifications/unsubscribe-auth/AE2MWR6NA6WCRXIN3TP2JGDQKFJSRANCNFSM4IXG65PA><br>
> .<br>
><br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3275?email_source=notifications&email_token=AJFFTNRZFM6RBPN2LIE4MWTQKFKDBA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66CTLY#issuecomment-532425135">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXTPLPTI6QYRDZUD2TQKFKDBANCNFSM4IXG65PA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNSHLAKGVLWZWD7CHV3QKFKDBA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66CTLY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3275?email_source=notifications\u0026email_token=AJFFTNRZFM6RBPN2LIE4MWTQKFKDBA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66CTLY#issuecomment-532425135",
"url": "https://github.com/bisq-network/bisq/pull/3275?email_source=notifications\u0026email_token=AJFFTNRZFM6RBPN2LIE4MWTQKFKDBA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66CTLY#issuecomment-532425135",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>