<p>The code review requirement is universal. Code author and code venue are irrelevant for the review requirement. This is simply the best software engineering and security practice.</p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=13068859" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/woodser">@woodser</a> would it make sense for you to break the library into relatively small <code>monero-wallet-rpc</code> wrapper and the rest of it?</p>
<p>The goal is to minimize the code that effectively becomes part of Bisq (and so must be analyzed). Sorry for the headache. Trying to find a solution.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3275?email_source=notifications&email_token=AJFFTNXSU57CMKNX2AATDMLQKJVQRA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7A6XNA#issuecomment-532802484">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTEXFCAL4ATON5OCYLQKJVQRANCNFSM4IXG65PA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNVLNPSTGHIFDQF45ODQKJVQRA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7A6XNA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3275?email_source=notifications\u0026email_token=AJFFTNXSU57CMKNX2AATDMLQKJVQRA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7A6XNA#issuecomment-532802484",
"url": "https://github.com/bisq-network/bisq/pull/3275?email_source=notifications\u0026email_token=AJFFTNXSU57CMKNX2AATDMLQKJVQRA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7A6XNA#issuecomment-532802484",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>