<p>The <code>monero-java</code> is a sophisticated project on its own with <strong>18K+ Java LOC</strong> and <strong>1.5K C++ LOC</strong>.</p>
<p>Also it's not like we only need 2% of this that we could maybe pull and embed directly into Bisq. We need roughly the whole thing.</p>
<p>So I suggest against embedding <code>monero-java</code> into Bisq. If we agree to use it then it should be external dependency fully verified with gradle witness.</p>
<p>I also want to reiterate what I already said. This PR is way too big. The initial step should be maybe just correctly referencing <code>monero-java</code> in a safe and cross-platform manner with any trivial/example usage of this in a developer mode.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3275?email_source=notifications&email_token=AJFFTNTPPAFGEBESFZIABWDQKH7OLA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67TMZA#issuecomment-532624996">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQP5QJIX3OYFFKGYOLQKH7OLANCNFSM4IXG65PA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNVZSOOYP64CAI7MDRDQKH7OLA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67TMZA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3275?email_source=notifications\u0026email_token=AJFFTNTPPAFGEBESFZIABWDQKH7OLA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67TMZA#issuecomment-532624996",
"url": "https://github.com/bisq-network/bisq/pull/3275?email_source=notifications\u0026email_token=AJFFTNTPPAFGEBESFZIABWDQKH7OLA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67TMZA#issuecomment-532624996",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>