<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=20237127" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/niyid">@niyid</a></p>
<p>Wouldn't you end up essentially re-writing MoneroWalletRpc.java?  The only thing extra that class does is translates monero-wallet-rpc's hodgepodge API to a clear model definition intended for long term use.  The purpose of the library is to avoid the need for application developers to roll their own binding with non-uniform APIs.  The library already provides extensive tests, a clear model definition, multisignature support, and the ability to switch to a native wallet binding with the same API.  I do not see why we would not use that as a matter of code review.</p>
<p>I am working on uploading the <code>monero-java</code> project to the Maven repository.  I can change the POM to package the project as POM instead of JAR, if that would be useful.</p>
<p>FYI we're on Bisq's Slack workspace.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3275?email_source=notifications&email_token=AJFFTNREE55P3IO7UUANRF3QKI6WTA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ALQWQ#issuecomment-532723802">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQXRPF27MCYLYOT7STQKI6WTANCNFSM4IXG65PA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNUQV4T3A2RW4ISSOMLQKI6WTA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ALQWQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3275?email_source=notifications\u0026email_token=AJFFTNREE55P3IO7UUANRF3QKI6WTA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ALQWQ#issuecomment-532723802",
"url": "https://github.com/bisq-network/bisq/pull/3275?email_source=notifications\u0026email_token=AJFFTNREE55P3IO7UUANRF3QKI6WTA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ALQWQ#issuecomment-532723802",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>