<blockquote>
<p>NACK</p>
<p>Actually it does not behave as i would like:</p>
<p>If its not a long line it makes it a one-liner. I prefer linebreaks at all non-trivial stream expressions for better redibility.</p>
<pre><code> public Optional<TxOutput> getLockupTxOutput(String txId) {
        return getTx(txId).flatMap(tx -> tx.getTxOutputs().stream().filter(this::isLockupOutput).findFirst());
    }
</code></pre>
<pre><code>   public Optional<TxOutput> getLockupTxOutput(String txId) {
        return getTx(txId).flatMap(tx -> tx.getTxOutputs().stream()
                .filter(this::isLockupOutput)
                .findFirst());
    }
</code></pre>
</blockquote>
<p>Unfortunately merged it already because of the utACk before. <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1999" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/christophsturm">@christophsturm</a> could you address the comments in another PR?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3296?email_source=notifications&email_token=AJFFTNRPA6GUI4U6PFATMF3QKOGSFA5CNFSM4IYKTCR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7DXXGI#issuecomment-533167001">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNW357EC4ITF6Q7P4MTQKOGSFANCNFSM4IYKTCRQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNRLUHADIDYBBD4F3KTQKOGSFA5CNFSM4IYKTCR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7DXXGI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3296?email_source=notifications\u0026email_token=AJFFTNRPA6GUI4U6PFATMF3QKOGSFA5CNFSM4IYKTCR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7DXXGI#issuecomment-533167001",
"url": "https://github.com/bisq-network/bisq/pull/3296?email_source=notifications\u0026email_token=AJFFTNRPA6GUI4U6PFATMF3QKOGSFA5CNFSM4IYKTCR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7DXXGI#issuecomment-533167001",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>