<p>We have a bug with the handling of missing mailbox messaged from mediation result and the peers accept message (carrying the signature). This PR fixes that.</p>
<p>For testing shut down the other trade peer at each step after mediation gets closed.</p>
<ol>
<li>Mediation is opened</li>
<li>Bob shutd down</li>
<li>Alice accept result</li>
<li>Alice shuts down</li>
<li>Bob starts and accepts result</li>
<li>Alice starts and sees the trade got closed</li>
</ol>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/3310'>https://github.com/bisq-network/bisq/pull/3310</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Add missing handling for mailbox messages</li>
  <li>Fix potential ConcurrentModificationException</li>
  <li>Avoid that the mediation result popup is shown</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3310/files#diff-0">core/src/main/java/bisq/core/trade/protocol/TradeProtocol.java</a>
    (16)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3310/files#diff-1">core/src/main/java/bisq/core/trade/protocol/tasks/mediation/ProcessMediatedPayoutTxPublishedMessage.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3310/files#diff-2">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/TradeStepView.java</a>
    (45)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/3310.patch'>https://github.com/bisq-network/bisq/pull/3310.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/3310.diff'>https://github.com/bisq-network/bisq/pull/3310.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3310?email_source=notifications&email_token=AJFFTNT2FXCBRUPMMVTIVJDQK75QFA5CNFSM4IZFC772YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HM5I7DA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTDWDARVUWTP6NZ5GTQK75QFANCNFSM4IZFC77Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNS573WFHB25VDVQLKDQK75QFA5CNFSM4IZFC772YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HM5I7DA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3310?email_source=notifications\u0026email_token=AJFFTNT2FXCBRUPMMVTIVJDQK75QFA5CNFSM4IZFC772YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HM5I7DA",
"url": "https://github.com/bisq-network/bisq/pull/3310?email_source=notifications\u0026email_token=AJFFTNT2FXCBRUPMMVTIVJDQK75QFA5CNFSM4IZFC772YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HM5I7DA",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>