<p><b>@blabno</b> requested changes on this pull request.</p>

<p>NACK per comments.</p>
<p>Squash commits into one, keeping proper commit message.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3110#discussion_r329407108">assets/src/main/java/bisq/asset/coins/Ndau.java</a>:</p>
<pre style='color:#555'>> +
+package bisq.asset.coins;
+
+import bisq.asset.AddressValidationResult;
+import bisq.asset.AddressValidator;
+import bisq.asset.Coin;
+import bisq.asset.RegexAddressValidator;
+
+
+public class Ndau extends Coin {
+
+    // note: ndau addresses contain an internal checksum which was deemed too complicated to include here.
+    // this regex performs superficial validation, but there is a large space of addresses marked valid
+    // by this regex which are not in fact valid ndau addresses. For actual ndau address validation,
+    // use the Address class in github.com/oneiro-ndev/ndauj (java) or github.com/oneiro-ndev/ndaumath/pkg/address (go).
+    private static AddressValidator validator = new RegexAddressValidator("nd[anexbm][abcdefghijkmnpqrstuvwxyz23456789]{45}");
</pre>
<p>There is no need to make this an object property. Move validator instantiation and declaration into constructor.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3110#discussion_r329407144">assets/src/main/java/bisq/asset/coins/Ndau.java</a>:</p>
<pre style='color:#555'>> +import bisq.asset.AddressValidationResult;
+import bisq.asset.AddressValidator;
+import bisq.asset.Coin;
+import bisq.asset.RegexAddressValidator;
+
+
+public class Ndau extends Coin {
+
+    // note: ndau addresses contain an internal checksum which was deemed too complicated to include here.
+    // this regex performs superficial validation, but there is a large space of addresses marked valid
+    // by this regex which are not in fact valid ndau addresses. For actual ndau address validation,
+    // use the Address class in github.com/oneiro-ndev/ndauj (java) or github.com/oneiro-ndev/ndaumath/pkg/address (go).
+    private static AddressValidator validator = new RegexAddressValidator("nd[anexbm][abcdefghijkmnpqrstuvwxyz23456789]{45}");
+
+    public Ndau() {
+        super("ndau", "XND", Ndau.validator, Network.MAINNET);
</pre>
<p>Mainnet is the default value, so no need for that parameter.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3110#discussion_r329407169">assets/src/main/java/bisq/asset/coins/Ndau.java</a>:</p>
<pre style='color:#555'>> +import bisq.asset.AddressValidationResult;
+import bisq.asset.AddressValidator;
+import bisq.asset.Coin;
+import bisq.asset.RegexAddressValidator;
+
+
+public class Ndau extends Coin {
+
+    // note: ndau addresses contain an internal checksum which was deemed too complicated to include here.
+    // this regex performs superficial validation, but there is a large space of addresses marked valid
+    // by this regex which are not in fact valid ndau addresses. For actual ndau address validation,
+    // use the Address class in github.com/oneiro-ndev/ndauj (java) or github.com/oneiro-ndev/ndaumath/pkg/address (go).
+    private static AddressValidator validator = new RegexAddressValidator("nd[anexbm][abcdefghijkmnpqrstuvwxyz23456789]{45}");
+
+    public Ndau() {
+        super("ndau", "XND", Ndau.validator, Network.MAINNET);
</pre>
<p>Name of asset should be uppercased I guess.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3110?email_source=notifications&email_token=AJFFTNUJUEG62PCIDH55IWDQMGAJFA5CNFSM4INQXLPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGIYASI#pullrequestreview-294748233">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUBJI4N7E5EWUBIMDLQMGAJFANCNFSM4INQXLPA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNWRAJX67TZDPSHLVFTQMGAJFA5CNFSM4INQXLPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGIYASI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3110?email_source=notifications\u0026email_token=AJFFTNUJUEG62PCIDH55IWDQMGAJFA5CNFSM4INQXLPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGIYASI#pullrequestreview-294748233",
"url": "https://github.com/bisq-network/bisq/pull/3110?email_source=notifications\u0026email_token=AJFFTNUJUEG62PCIDH55IWDQMGAJFA5CNFSM4INQXLPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGIYASI#pullrequestreview-294748233",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>