<p><b>@blabno</b> requested changes on this pull request.</p>

<p>NACK per comments.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3252#discussion_r329408288">assets/src/main/java/bisq/asset/coins/BitcoinV.java</a>:</p>
<pre style='color:#555'>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.asset.coins;
+
+import bisq.asset.Base58BitcoinAddressValidator;
+import bisq.asset.Coin;
+
+import org.bitcoinj.core.NetworkParameters;
+import org.bitcoinj.params.MainNetParams;
+
+public abstract class BitcoinV extends Coin {
</pre>
<p>No need for abstraction here. Make this class use mainnet (default params).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3252?email_source=notifications&email_token=AJFFTNSMBBXX7OLF2QHC2HDQMGBI3A5CNFSM4IWLGCVKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGIYMAA#pullrequestreview-294749696">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTCGYPGMPS5IUUKZW3QMGBI3ANCNFSM4IWLGCVA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNW3YHD2WQWFOLGJ75LQMGBI3A5CNFSM4IWLGCVKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGIYMAA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3252?email_source=notifications\u0026email_token=AJFFTNSMBBXX7OLF2QHC2HDQMGBI3A5CNFSM4IWLGCVKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGIYMAA#pullrequestreview-294749696",
"url": "https://github.com/bisq-network/bisq/pull/3252?email_source=notifications\u0026email_token=AJFFTNSMBBXX7OLF2QHC2HDQMGBI3A5CNFSM4IWLGCVKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGIYMAA#pullrequestreview-294749696",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>