<p><b>@christophsturm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3326#discussion_r329935268">core/src/test/java/bisq/core/btc/wallet/BsqWalletServiceTest.java</a>:</p>
<pre style='color:#555'>> +import bisq.core.user.Preferences;
+import bisq.core.util.ParsingUtils;
+
+import org.bitcoinj.core.Coin;
+import org.bitcoinj.params.UnitTestParams;
+import org.bitcoinj.utils.MonetaryFormat;
+import org.bitcoinj.wallet.Wallet;
+
+import org.junit.Test;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class BsqWalletServiceTest {
+    @Test(expected = InsufficientBsqException.class)
+    public void throwsExceptionWhenFundsAreInsufficient() throws TransactionVerificationException, WalletException, BsqChangeBelowDustException, InsufficientBsqException {
</pre>
<p>yes its not very readable, and its not a very useful test, the main motivation for this pr is to make the wallet service testable at all.</p>
<p>All the test code is basically "given", the last line is "when", and the "then" is in the annotation at the top (we expect a exception).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3326?email_source=notifications&email_token=AJFFTNTSLNYDSSQSK6IYILDQMMDA3A5CNFSM4I2LUKX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGOBKAI#discussion_r329935268">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUTJO5BEVSGQKBUOJDQMMDA3ANCNFSM4I2LUKXQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNUZTBEW2LQAOWVUT7TQMMDA3A5CNFSM4I2LUKX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGOBKAI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3326?email_source=notifications\u0026email_token=AJFFTNTSLNYDSSQSK6IYILDQMMDA3A5CNFSM4I2LUKX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGOBKAI#discussion_r329935268",
"url": "https://github.com/bisq-network/bisq/pull/3326?email_source=notifications\u0026email_token=AJFFTNTSLNYDSSQSK6IYILDQMMDA3A5CNFSM4I2LUKX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGOBKAI#discussion_r329935268",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>