<blockquote>
<p>I don't see the benefit of rewriting for the sake of rewriting.</p>
</blockquote>
<p>Completely agree. I'm proposing a rewrite for the sake of:</p>
<ul>
<li>security</li>
<li>productivity</li>
<li>extensibility</li>
</ul>
<p>And only based on the assumption that the overlap between v1 and v2 is not very large / easy to re-implement. ie. it will be a hard-fork with completely new code for handling trading - which means a rewrite of some portion of the code anyway.</p>
<blockquote>
<p>What might make more sense is to define the v2 protocol strictly and allow for different clients using something like a <code>bisqd</code> with the api.</p>
</blockquote>
<p>A well defined protocol contract for <code>v2</code> would certainly be good.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/proposals/issues/125?email_source=notifications&email_token=AJFFTNVPQL5AXYYLBVRXJGTQNKVXVA5CNFSM4I5MQO72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAO57LY#issuecomment-538828719">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNS2OL4FQD7Y35M4CXDQNKVXVANCNFSM4I5MQO7Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNW5SOM62ODNV4S5T3TQNKVXVA5CNFSM4I5MQO72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAO57LY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/proposals/issues/125?email_source=notifications\u0026email_token=AJFFTNVPQL5AXYYLBVRXJGTQNKVXVA5CNFSM4I5MQO72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAO57LY#issuecomment-538828719",
"url": "https://github.com/bisq-network/proposals/issues/125?email_source=notifications\u0026email_token=AJFFTNVPQL5AXYYLBVRXJGTQNKVXVA5CNFSM4I5MQO72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAO57LY#issuecomment-538828719",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>