<p><b>@chimp1984</b> requested changes on this pull request.</p>
<p>NACK - if my interpretation is correct.</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3366#discussion_r331836065">desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java</a>:</p>
<pre style='color:#555'>> + bsqWalletService,
+ btcWalletService,
+ daoFacade,
+ // Use tx.getIncludedInBestChainAt() when available, otherwise use tx.getUpdateTime()
+ transaction.getIncludedInBestChainAt() != null ? transaction.getIncludedInBestChainAt() : transaction.getUpdateTime(),
+ bsqFormatter);
+ }).filter(new Predicate<BsqTxListItem>() {
+ @Override
+ public boolean test(BsqTxListItem t) {
+ return TxType.COMPENSATION_REQUEST.equals(t.getTxType()) || TxType.REIMBURSEMENT_REQUEST.equals(t.getTxType());
+ }
+ }).mapToLong(i -> i.getAmount().getValue()).sum();
+
+ reputationBalanceTextField.setText(bsqFormatter.formatCoinWithCode(Coin.valueOf(reputationSum)));
+ }).start();
+ }
</pre>
<p>If you refer with reputation to the merit used in voting this is not a correct implementation.<br>
The merit has a decline function over 2 years. The DAO domain contains methods to get that correct value (see in UI code for voting as there it is displayed).<br>
Also you should avoid to call the UI thread from other threads, can cause issues.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3366?email_source=notifications&email_token=AJFFTNVGQOEY7I6RL5OXQRLQNKUM5A5CNFSM4I5476X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHAXQ6I#pullrequestreview-297891961">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRLENP52V2A3UBSYF3QNKUM5ANCNFSM4I5476XQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AJFFTNWYDIP2E2727EGFF4TQNKUM5A5CNFSM4I5476X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHAXQ6I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3366?email_source=notifications\u0026email_token=AJFFTNVGQOEY7I6RL5OXQRLQNKUM5A5CNFSM4I5476X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHAXQ6I#pullrequestreview-297891961",
"url": "https://github.com/bisq-network/bisq/pull/3366?email_source=notifications\u0026email_token=AJFFTNVGQOEY7I6RL5OXQRLQNKUM5A5CNFSM4I5476X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHAXQ6I#pullrequestreview-297891961",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>