<p>When requesting data from a seednode the <code>GetDataReponse</code>  <a href="https://github.com/bisq-network/bisq/blob/master/common/src/main/proto/pb.proto#L97"><code>persistable_network_payload_items</code></a> array contains many <a href="https://github.com/bisq-network/bisq/blob/master/common/src/main/proto/pb.proto#L594-L611"><code>TradeStatistics2</code></a> messages that are actually duplicates.<br>
ie. Same <code>offer_id</code> but different <code>hash</code> fields. It appears as though <a href="https://github.com/bisq-network/bisq/blob/master/core/src/main/java/bisq/core/trade/statistics/TradeStatistics2.java#L157">this hashing function</a> is infact non-deterministic and truly yields different results in prod in the wild (unlike the other non-deterministic hashing issue that does not appear to manifest itself).</p>
<p>Here is an example of 2 TradingStatistics2 messages received from the seed nodes:</p>
<pre><code>{
        "direction": "SELL",
        "price": "7199.12320000",
        "amount": "0.03000000",
        "volume": "215.97360000",
        "payment_method": "SEPA",
        "trade_id": "DAtKiw-6951da2b-38e0-44ed-9b17-4935cf85aff3-117",
        "trade_date": "1571920381023",
        "hash": "7318687539069de402ca208ce8c8dfe93aa3326e"
      },
      {
        "direction": "SELL",
        "price": "7199.12320000",
        "amount": "0.03000000",
        "volume": "215.97360000",
        "payment_method": "SEPA",
        "trade_id": "DAtKiw-6951da2b-38e0-44ed-9b17-4935cf85aff3-117",
        "trade_date": "1571920381023",
        "hash": "7a229b08c04ded7f2247feb6b25d35f0335dbef6"
      }
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/3468?email_source=notifications&email_token=AJFFTNXWFOIBOY5WTLO5EJLQQL5EPA5CNFSM4JFD4X6KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HUMXZJQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTCFA5KKZ4NS6YLOQTQQL5EPANCNFSM4JFD4X6A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQDL5SBJI4F4MG37SDQQL5EPA5CNFSM4JFD4X6KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HUMXZJQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/3468?email_source=notifications\u0026email_token=AJFFTNXWFOIBOY5WTLO5EJLQQL5EPA5CNFSM4JFD4X6KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HUMXZJQ",
"url": "https://github.com/bisq-network/bisq/issues/3468?email_source=notifications\u0026email_token=AJFFTNXWFOIBOY5WTLO5EJLQQL5EPA5CNFSM4JFD4X6KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HUMXZJQ",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>