<p><b>@freimair</b> requested changes on this pull request.</p>
<p>Ack, but please use the <code>@Setter</code> instead of create the setter method by hand</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3329#discussion_r342012986">core/src/main/java/bisq/core/payment/payload/PaymentAccountPayload.java</a>:</p>
<pre style='color:#555'>> @@ -70,6 +73,11 @@
@Nullable
protected final Map<String, String> excludeFromJsonDataMap;
+ @JsonExclude
+ @Getter(AccessLevel.NONE)
+ @Setter(AccessLevel.NONE)
</pre>
⬇️ Suggested change
<pre style="color: #555">- @Setter(AccessLevel.NONE)
+ @Setter
</pre>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3329#discussion_r342013103">core/src/main/java/bisq/core/payment/payload/PaymentAccountPayload.java</a>:</p>
<pre style='color:#555'>> +
+ public void setPaymentDetails(String paymentDetails) {
+ this.paymentDetails = paymentDetails;
+ }
</pre>
<p>remove</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3329?email_source=notifications&email_token=AJFFTNQRVFTSNQMC7G5KDOLQSAESDA5CNFSM4I2W3OQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKE4YGY#pullrequestreview-311020571">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRK6QFMGPCBTPITLK3QSAESDANCNFSM4I2W3OQQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRFFDVQOMOHO42AHILQSAESDA5CNFSM4I2W3OQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKE4YGY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3329?email_source=notifications\u0026email_token=AJFFTNQRVFTSNQMC7G5KDOLQSAESDA5CNFSM4I2W3OQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKE4YGY#pullrequestreview-311020571",
"url": "https://github.com/bisq-network/bisq/pull/3329?email_source=notifications\u0026email_token=AJFFTNQRVFTSNQMC7G5KDOLQSAESDA5CNFSM4I2W3OQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKE4YGY#pullrequestreview-311020571",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>