<p><b>@julianknutsen</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3562#discussion_r343219464">p2p/src/main/java/bisq/network/p2p/peers/getdata/GetDataRequestHandler.java</a>:</p>
<pre style='color:#555'>>                  .map(Map.Entry::getValue)
                 .collect(Collectors.toSet());
+        if (maxSize.get() <= 0) {
+            log.warn("The peer request caused too much ProtectedStorageEntry entries to get delivered. We limited the entries for the response to {} entries", MAX_ENTRIES);
</pre>
<p>Is the UpdateDataRequest the only way to retrieve items > 10,000? What if the total set is larger than what the Initial & Update can handle? Is there a periodic on as well to sync over time?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3562?email_source=notifications&email_token=AJFFTNQQS6T724AEPH3W62LQSL27RA5CNFSM4JJFWZG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKQ6R4Q#pullrequestreview-312600818">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUQDKMQ2WOXIR5ZC2DQSL27RANCNFSM4JJFWZGQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNX3HEHESHGUVKC3DYLQSL27RA5CNFSM4JJFWZG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKQ6R4Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3562?email_source=notifications\u0026email_token=AJFFTNQQS6T724AEPH3W62LQSL27RA5CNFSM4JJFWZG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKQ6R4Q#pullrequestreview-312600818",
"url": "https://github.com/bisq-network/bisq/pull/3562?email_source=notifications\u0026email_token=AJFFTNQQS6T724AEPH3W62LQSL27RA5CNFSM4JJFWZG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKQ6R4Q#pullrequestreview-312600818",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>