<p><b>@sqrrm</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3566#discussion_r343158422">core/src/main/java/bisq/core/app/BisqSetup.java</a>:</p>
<pre style='color:#555'>> + String details = null;
+ if (txId.equals(trade.getDepositTxId())) {
+ details = Res.get("popup.warning.trade.txRejected.deposit");
+ }
+ if (txId.equals(trade.getOffer().getOfferFeePaymentTxId()) || txId.equals(trade.getTakerFeeTxId())) {
+ details = Res.get("popup.warning.trade.txRejected.tradeFee");
+ }
+
+ if (details != null) {
+ // We delay to avoid concurrent modification exceptions
+ String finalDetails = details;
+ UserThread.runAfter(() -> {
+ trade.setErrorMessage(newValue.getMessage());
+ rejectedTxErrorMessageHandler.accept(Res.get("popup.warning.trade.txRejected",
+ finalDetails, trade.getShortId(), txId));
+ tradeManager.addTradeToFailedTrades(trade);
</pre>
<p>At this point just getting things more stable is good. Perhaps we could look at it if it's recurring event that people lose their fee this way.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3566?email_source=notifications&email_token=AJFFTNWHEYMUGAL5SRZGQZ3QSLO4RA5CNFSM4JJPDRB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKQKNQQ#discussion_r343158422">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNS53URYLG5P3SEIHK3QSLO4RANCNFSM4JJPDRBQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRX22JASGPTSUYSPR3QSLO4RA5CNFSM4JJPDRB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKQKNQQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3566?email_source=notifications\u0026email_token=AJFFTNWHEYMUGAL5SRZGQZ3QSLO4RA5CNFSM4JJPDRB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKQKNQQ#discussion_r343158422",
"url": "https://github.com/bisq-network/bisq/pull/3566?email_source=notifications\u0026email_token=AJFFTNWHEYMUGAL5SRZGQZ3QSLO4RA5CNFSM4JJPDRB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKQKNQQ#discussion_r343158422",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>