<p><b>@julianknutsen</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3568#discussion_r343991655">p2p/src/main/java/bisq/network/p2p/storage/payload/ProtectedStorageEntry.java</a>:</p>
<pre style='color:#555'>> @@ -41,25 +43,29 @@
     private int sequenceNumber;
     private byte[] signature;
     private long creationTimeStamp;
+    transient private final Clock clock;
</pre>
<p>After sleeping on it and coming back to it today, I don't like the idea of storing the clock in the object. Not necessarily because it is value-heavy, but because it is more testable and cleaner to pass in a new instance if needed instead of relying on the one that was generated at instantiation time</p>
<p>I've updated the stack with the patch that removes it in favor of passing it into the functions that need it.</p>
<p>After reviewing and refactoring this code over the last few weeks I am actually of the opinion that this needs more OO not less to stay maintainable and testable. Having one large integration test for everything isn't a great path forward. I've got a stack almost ready that leverages the inheritance that already exists to make the code a lot easier test and deduplicates a lot of the redundant helper functions.</p>
<p>I'll send it out tomorrow and whoever is interested can take a look and see if the pros outweigh the cons.</p>
<p>Thanks again for your feedback.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3568?email_source=notifications&email_token=AJFFTNVHM3UBPTIOH7K5DQDQSTYWJA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKZ75UQ#discussion_r343991655">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTLBFL27K6BEANCSYTQSTYWJANCNFSM4JKA4E5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWD5NSMLM7IGW6OF6TQSTYWJA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKZ75UQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3568?email_source=notifications\u0026email_token=AJFFTNVHM3UBPTIOH7K5DQDQSTYWJA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKZ75UQ#discussion_r343991655",
"url": "https://github.com/bisq-network/bisq/pull/3568?email_source=notifications\u0026email_token=AJFFTNVHM3UBPTIOH7K5DQDQSTYWJA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKZ75UQ#discussion_r343991655",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>