<p><b>@chimp1984</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3568#discussion_r343945871">p2p/src/main/java/bisq/network/p2p/storage/payload/ProtectedStorageEntry.java</a>:</p>
<pre style='color:#555'>> @@ -41,25 +43,29 @@
     private int sequenceNumber;
     private byte[] signature;
     private long creationTimeStamp;
+    transient private final Clock clock;
</pre>
<p>I did not have time to look closer but adding Clock to ProtectedStorageEntry does not feel right to me. Using injecting for service classes is fine and adding clock there, but I think it should not be part of the value objects.<br>
Those methods on ProtectedStorageEntry using time could be moved to the service class and the ProtectedStorageEntry is passed as an object (just a rough idea, had not looked closer to the PR...). Those heavy value objects doing too much and having external dependencies (time) have been a bad idea anyway and maybe thats a good opportunity to refactor that.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3568?email_source=notifications&email_token=AJFFTNRMAUYYE42NN555NSTQSSZJ3A5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKZRXPQ#discussion_r343945871">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTH72JY35SOW5NADLLQSSZJ3ANCNFSM4JKA4E5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNV7D2B54FLV3GI2553QSSZJ3A5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKZRXPQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3568?email_source=notifications\u0026email_token=AJFFTNRMAUYYE42NN555NSTQSSZJ3A5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKZRXPQ#discussion_r343945871",
"url": "https://github.com/bisq-network/bisq/pull/3568?email_source=notifications\u0026email_token=AJFFTNRMAUYYE42NN555NSTQSSZJ3A5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKZRXPQ#discussion_r343945871",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>