<p><b>@julianknutsen</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3568#discussion_r343701833">p2p/src/main/java/bisq/network/p2p/storage/payload/ProtectedStorageEntry.java</a>:</p>
<pre style='color:#555'>> @@ -41,25 +43,29 @@
     private int sequenceNumber;
     private byte[] signature;
     private long creationTimeStamp;
+    transient private final Clock clock;
</pre>
<p>There is an alternative here that doesn't involve storing the clock inside the data structure. The Public API methods that need a clock (ctor/refresh/backdate/isExpired) can take one as a parameter for the work they need individually. This will involve plumbing a Clock into OfferBookService, but that is easy enough.</p>
<p>The protobuf deserialization path still needs access to a clock, so it will still need the resolver instance where it can be used in maybeAdjustCreationTimeStamp().</p>
<p>If someone has a strong opinion on this or maybe <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1999" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/christophsturm">@christophsturm</a> can comment on what he envisioned with the clock injections throughout the code. I'd rather stick to a common pattern to make this work consistent in the future.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3568?email_source=notifications&email_token=AJFFTNUVENVRMZCSDW35IB3QSQVRTA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKXDR6Y#pullrequestreview-313407739">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWJMYCPF6OUOJ4WYTLQSQVRTANCNFSM4JKA4E5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXOBYDPJ5FAC5FYP43QSQVRTA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKXDR6Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3568?email_source=notifications\u0026email_token=AJFFTNUVENVRMZCSDW35IB3QSQVRTA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKXDR6Y#pullrequestreview-313407739",
"url": "https://github.com/bisq-network/bisq/pull/3568?email_source=notifications\u0026email_token=AJFFTNUVENVRMZCSDW35IB3QSQVRTA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKXDR6Y#pullrequestreview-313407739",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>