<p><b>@julianknutsen</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3554#discussion_r344448953">p2p/src/test/java/bisq/network/p2p/storage/mocks/AppendOnlyDataStoreServiceFake.java</a>:</p>
<pre style='color:#555'>> + * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.network.p2p.storage.mocks;
+
+import bisq.network.p2p.storage.P2PDataStorage;
+import bisq.network.p2p.storage.payload.PersistableNetworkPayload;
+import bisq.network.p2p.storage.persistence.AppendOnlyDataStoreService;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public class AppendOnlyDataStoreServiceFake extends AppendOnlyDataStoreService {
</pre>
<p>This just uses standard terms for test objects so developers can understand the behavior and contract.  I use Fake, Dummy, and Stub as defined here: <a href="https://martinfowler.com/articles/mocksArentStubs.html#TheDifferenceBetweenMocksAndStubs" rel="nofollow">https://martinfowler.com/articles/mocksArentStubs.html#TheDifferenceBetweenMocksAndStubs</a></p>
<p>Specifically, fakes have working implementations of the interface, but use optimizations to make them easy to use in tests. For these, an in-memory map is used instead of persistent storage.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3554?email_source=notifications&email_token=AJFFTNSG4SGFYBFSTB5KOO3QS3JVNA5CNFSM4JIXNDR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCK75YIA#discussion_r344448953">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWUWGWC4K6X4SBZU4DQS3JVNANCNFSM4JIXNDRQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWBP7XVZPT6N7ISQWDQS3JVNA5CNFSM4JIXNDR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCK75YIA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3554?email_source=notifications\u0026email_token=AJFFTNSG4SGFYBFSTB5KOO3QS3JVNA5CNFSM4JIXNDR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCK75YIA#discussion_r344448953",
"url": "https://github.com/bisq-network/bisq/pull/3554?email_source=notifications\u0026email_token=AJFFTNSG4SGFYBFSTB5KOO3QS3JVNA5CNFSM4JIXNDR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCK75YIA#discussion_r344448953",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>