<p><b>@ripcurlx</b> requested changes on this pull request.</p>

<p>NACK - I stopped reviewing (please see my comments). Actually everything is wrong in this PR. Please have a look what you are doing in your code before pushing changes or submitting PRs.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3329#discussion_r345210592">core/src/main/java/bisq/core/trade/protocol/tasks/ApplyFilter.java</a>:</p>
<pre style='color:#555'>> @@ -60,8 +61,9 @@ protected void run() {
                 failed("Payment method is banned.\n" +
                         "Payment method=" + trade.getOffer().getPaymentMethod().getId());
             } else if (filterManager.isPeersPaymentAccountDataAreBanned(paymentAccountPayload, appliedPaymentAccountFilter)) {
+               String paymentDetails = Res.getWithCol("payment.altcoin.sender.address", trade.getOffer().getCurrencyCode());
</pre>
<p>This absolutely wrong it would change the paymentDetails displayed e.g. for MoneyBeam you would replace <code>Res.get(paymentMethodId) + " - " + Res.getWithCol("payment.account") + " " + accountId;</code> with <code>Res.getWithCol("payment.altcoin.sender.address", trade.getOffer().getCurrencyCode());</code></p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3329#discussion_r345213363">desktop/src/main/java/bisq/desktop/main/overlays/windows/ContractWindow.java</a>:</p>
<pre style='color:#555'>> @@ -175,9 +179,9 @@ private void addContent() {
                 nrOfDisputesAsBuyer + " / " + nrOfDisputesAsSeller);
 
         addConfirmationLabelTextFieldWithCopyIcon(gridPane, ++rowIndex, Res.get("shared.paymentDetails", Res.get("shared.buyer")),
-                contract.getBuyerPaymentAccountPayload().getPaymentDetails()).second.setMouseTransparent(false);
+                       buyerPaymentDetails).second.setMouseTransparent(false);
</pre>
<p>You are removing  the real payment details with e.g. <code>Sender's BTC address</code></p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3329#discussion_r345213412">desktop/src/main/java/bisq/desktop/main/overlays/windows/ContractWindow.java</a>:</p>
<pre style='color:#555'>>          addConfirmationLabelTextFieldWithCopyIcon(gridPane, ++rowIndex, Res.get("shared.paymentDetails", Res.get("shared.seller")),
-                sellerPaymentAccountPayload.getPaymentDetails()).second.setMouseTransparent(false);
+                sellerPaymentDetails).second.setMouseTransparent(false);
</pre>
<p>same here</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3329?email_source=notifications&email_token=AJFFTNSND52YUD2EGCAR6FDQTKYCPA5CNFSM4I2W3OQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLHLLBI#pullrequestreview-315536773">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTM5TTFAS3C5MC2BTTQTKYCPANCNFSM4I2W3OQQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNSF4RFASUGH2HWXEQLQTKYCPA5CNFSM4I2W3OQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLHLLBI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3329?email_source=notifications\u0026email_token=AJFFTNSND52YUD2EGCAR6FDQTKYCPA5CNFSM4I2W3OQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLHLLBI#pullrequestreview-315536773",
"url": "https://github.com/bisq-network/bisq/pull/3329?email_source=notifications\u0026email_token=AJFFTNSND52YUD2EGCAR6FDQTKYCPA5CNFSM4I2W3OQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLHLLBI#pullrequestreview-315536773",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>