<p><b>@julianknutsen</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3568#discussion_r346926130">p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java</a>:</p>
<pre style='color:#555'>> @@ -121,6 +124,8 @@
     private final Set<ProtectedDataStoreListener> protectedDataStoreListeners = new CopyOnWriteArraySet<>();
     private final Clock clock;
 
+    protected int maxSequenceNumberMapSizeBeforePurge;
</pre>
<p><a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/julianknutsen/bisq/commit/850cd9180213f396180b447d6164e7e8c3900ac2/hovercard" href="https://github.com/julianknutsen/bisq/commit/850cd9180213f396180b447d6164e7e8c3900ac2">julianknutsen@<tt>850cd91</tt></a></p>
<p>Guice is really new to me, but from what I found I think this solution will be better. The App will just inject the static value and the tests can pass it in through the normal constructor.</p>
<p>The constant didn't feel right to put in NetworkOptionKeys so let me your preference for it.</p>
<p>Let me know your comments and I'll create the PR to fix this up.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3568?email_source=notifications&email_token=AJFFTNUAJZGBV3HRCTAGNWDQT3KGVA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLYJDUI#discussion_r346926130">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWYZ3YIECXCVEKL6OLQT3KGVANCNFSM4JKA4E5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWMTPSA6C4J3MZG3YDQT3KGVA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLYJDUI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3568?email_source=notifications\u0026email_token=AJFFTNUAJZGBV3HRCTAGNWDQT3KGVA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLYJDUI#discussion_r346926130",
"url": "https://github.com/bisq-network/bisq/pull/3568?email_source=notifications\u0026email_token=AJFFTNUAJZGBV3HRCTAGNWDQT3KGVA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLYJDUI#discussion_r346926130",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>