<p><b>@freimair</b> requested changes on this pull request.</p>

<p>utAck. However, see inline comment...</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3568#discussion_r346878233">p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java</a>:</p>
<pre style='color:#555'>> @@ -121,6 +124,8 @@
     private final Set<ProtectedDataStoreListener> protectedDataStoreListeners = new CopyOnWriteArraySet<>();
     private final Clock clock;
 
+    protected int maxSequenceNumberMapSizeBeforePurge;
</pre>
<p>can we have a</p>
⬇️ Suggested change
<pre style="color: #555">-    protected int maxSequenceNumberMapSizeBeforePurge;
+    protected static final int MAX_SEQUENCE_NUMBER_MAP_SIZE_BEFORE_PURGE;
</pre>

<p>or at least</p>
⬇️ Suggested change
<pre style="color: #555">-    protected int maxSequenceNumberMapSizeBeforePurge;
+    protected final int maxSequenceNumberMapSizeBeforePurge;
</pre>

<p>?</p>
<p>or as I am sure you thought about that, why did you decide against that in the first place?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3568?email_source=notifications&email_token=AJFFTNS2375RFEJ5VXEGOHTQT26HTA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLXZQOY#pullrequestreview-317691963">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTYFUDT5GXQICLOWZTQT26HTANCNFSM4JKA4E5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUYF7CJX6JQTL75HETQT26HTA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLXZQOY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3568?email_source=notifications\u0026email_token=AJFFTNS2375RFEJ5VXEGOHTQT26HTA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLXZQOY#pullrequestreview-317691963",
"url": "https://github.com/bisq-network/bisq/pull/3568?email_source=notifications\u0026email_token=AJFFTNS2375RFEJ5VXEGOHTQT26HTA5CNFSM4JKA4E5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLXZQOY#pullrequestreview-317691963",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>