<p>I don't merge this PR as the commits will be part of <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="523026697" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3609" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/3609/hovercard" href="https://github.com/bisq-network/bisq/pull/3609">#3609</a> anyways. So I'll close it as soon as <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="523026697" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3609" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/3609/hovercard" href="https://github.com/bisq-network/bisq/pull/3609">#3609</a> gets merged. In the future I might do it differently as I do it right now. If we have bigger changes that rely on each other and are pushed as separate PRs, it might be better to only merge the final PR (squash and merge) and use the other PRs for initial feedback. So we don't end up with in-progress commits in our git history. Still the title of the final PR will need some change as it should sum up the whole change. Within the descriptions we should reference all other closed PRs for documentation purpose.<br>
<a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1070734" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/freimair">@freimair</a> <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=8082291" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/julianknutsen">@julianknutsen</a> <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=23560607" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/sqrrm">@sqrrm</a> What do you think?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3587?email_source=notifications&email_token=AJFFTNSQTG4ETRSQYGO4ZQDQUKM7RA5CNFSM4JLJFJ5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEKP73Y#issuecomment-555024367">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWK6ENQZBZ5FJG6T5LQUKM7RANCNFSM4JLJFJ5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTEZEL7O2UAQHFPI4TQUKM7RA5CNFSM4JLJFJ5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEKP73Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3587?email_source=notifications\u0026email_token=AJFFTNSQTG4ETRSQYGO4ZQDQUKM7RA5CNFSM4JLJFJ5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEKP73Y#issuecomment-555024367",
"url": "https://github.com/bisq-network/bisq/pull/3587?email_source=notifications\u0026email_token=AJFFTNSQTG4ETRSQYGO4ZQDQUKM7RA5CNFSM4JLJFJ5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEKP73Y#issuecomment-555024367",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>