<p>As part of investigating <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="523198347" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3610" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/3610/hovercard" href="https://github.com/bisq-network/bisq/issues/3610">#3610</a>, I found another bug in how <code>ProtectedStorageEntry</code> objects are persisted to disk. The result is that a node starting up does not properly format the <code>GetData</code> request from the seed node leading to retransmission of <code>TempProposal</code> payloads that it already knows about.</p>
<p>I am already working on this area as part of <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="523920912" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/proposals/issues/140" data-hovercard-type="issue" data-hovercard-url="/bisq-network/proposals/issues/140/hovercard" href="https://github.com/bisq-network/proposals/issues/140">bisq-network/proposals#140</a> and it will likely show up as a failing test. Documenting this here in case people see behavior they don't understand.</p>
<h2>Tech Info</h2>
<p><code>ProtectedPayload</code> objects implementing the <code>PersistablePayload</code> interface are saved to disk by the <code>Sha256Ripemd160hash</code> but are loaded from disk expecting the <code>Sha256Hash</code>. This results in the keys in the hashmap being 20-bytes for the items loaded from disk and 32-bytes for the items sent from the seed node.</p>
<p>So, we ask the seednode to exclude the 20-byte key and it sends back the 32-byte key which both point to the exact same payload.</p>
<p>This is relevant for <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="523198347" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3610" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/3610/hovercard" href="https://github.com/bisq-network/bisq/issues/3610">#3610</a> because we need to understand the behavior of non-upgraded nodes and their ability to propagate old <code>TempProposals</code> to the network.</p>
<p>More to come with how to address it.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/3629?email_source=notifications&email_token=AJFFTNUAGG6IN5XGOCC2PDLQUMXSDA5CNFSM4JO4A2PKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2GJIKA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQZ6F5523NDXFJDDU3QUMXSDANCNFSM4JO4A2PA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXFBHHOQCU5S35S3WLQUMXSDA5CNFSM4JO4A2PKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2GJIKA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/3629?email_source=notifications\u0026email_token=AJFFTNUAGG6IN5XGOCC2PDLQUMXSDA5CNFSM4JO4A2PKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2GJIKA",
"url": "https://github.com/bisq-network/bisq/issues/3629?email_source=notifications\u0026email_token=AJFFTNUAGG6IN5XGOCC2PDLQUMXSDA5CNFSM4JO4A2PKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2GJIKA",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>