<p><b>@freimair</b> requested changes on this pull request.</p>

<p>IMO we could get away with mocking the <code>SeedNodeRepository</code> superclass, thus eliminating the dependency to <code>core</code>. Can you verify that this is correct?</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3126#discussion_r347342879">build.gradle</a>:</p>
<pre style='color:#555'>> @@ -205,6 +205,7 @@ configure(project(':common')) {
 configure(project(':p2p')) {
     dependencies {
         compile project(':common')
+        testCompile project(':core')
</pre>
⬇️ Suggested change
<pre style="color: #555">-        testCompile project(':core')
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3126#discussion_r347343095">p2p/src/test/java/bisq/network/p2p/MockNode.java</a>:</p>
<pre style='color:#555'>> + * under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or (at
+ * your option) any later version.
+ *
+ * Bisq is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.network.p2p;
+
+import bisq.core.network.p2p.seed.DefaultSeedNodeRepository;
</pre>
⬇️ Suggested change
<pre style="color: #555">-import bisq.core.network.p2p.seed.DefaultSeedNodeRepository;
+import bisq.network.p2p.seed.SeedNodeRepository;
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3126#discussion_r347343191">p2p/src/test/java/bisq/network/p2p/MockNode.java</a>:</p>
<pre style='color:#555'>> +
+public class MockNode {
+    @Getter
+    public NetworkNode networkNode;
+    @Getter
+    public PeerManager peerManager;
+    @Getter
+    public Set<Connection> connections;
+    @Getter
+    public int maxConnections;
+
+    public MockNode(int maxConnections) {
+        this.maxConnections = maxConnections;
+        networkNode = mock(NetworkNode.class);
+        Storage<PeerList> storage = new Storage<>(mock(File.class), mock(PersistenceProtoResolver.class), mock(CorruptedDatabaseFilesHandler.class));
+        peerManager = new PeerManager(networkNode, mock(DefaultSeedNodeRepository.class), new ClockWatcher(), maxConnections, storage);
</pre>
⬇️ Suggested change
<pre style="color: #555">-        peerManager = new PeerManager(networkNode, mock(DefaultSeedNodeRepository.class), new ClockWatcher(), maxConnections, storage);
+        peerManager = new PeerManager(networkNode, mock(SeedNodeRepository.class), new ClockWatcher(), maxConnections, storage);
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3126?email_source=notifications&email_token=AJFFTNUC2VOBOPIAWZA452LQUKAX5A5CNFSM4IORWVYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL4JLZI#pullrequestreview-318281189">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQQRZ5AXCK2F3E24VLQUKAX5ANCNFSM4IORWVYA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXUELAXLIZ2Q666KQDQUKAX5A5CNFSM4IORWVYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL4JLZI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3126?email_source=notifications\u0026email_token=AJFFTNUC2VOBOPIAWZA452LQUKAX5A5CNFSM4IORWVYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL4JLZI#pullrequestreview-318281189",
"url": "https://github.com/bisq-network/bisq/pull/3126?email_source=notifications\u0026email_token=AJFFTNUC2VOBOPIAWZA452LQUKAX5A5CNFSM4IORWVYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL4JLZI#pullrequestreview-318281189",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>