<p>Requested changes from <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="519017085" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3568" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/3568/hovercard" href="https://github.com/bisq-network/bisq/pull/3568">#3568</a></p>
<p>Instead of using a subclass that overwrites a value, utilize Guice<br>
to inject the real value of 10000 in the app and let the tests overwrite<br>
it with their own.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/3628'>https://github.com/bisq-network/bisq/pull/3628</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>[PR COMMENTS] Make maxSequenceNumberBeforePurge final</li>
  <li>[TESTS] Clean up 'Analyze Code' warnings</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3628/files#diff-0">p2p/src/main/java/bisq/network/p2p/P2PModule.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3628/files#diff-1">p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3628/files#diff-2">p2p/src/test/java/bisq/network/p2p/storage/P2PDataStoragePersistableNetworkPayloadTest.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3628/files#diff-3">p2p/src/test/java/bisq/network/p2p/storage/P2PDataStorageProtectedStorageEntryTest.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3628/files#diff-4">p2p/src/test/java/bisq/network/p2p/storage/P2PDataStorageRemoveExpiredTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3628/files#diff-5">p2p/src/test/java/bisq/network/p2p/storage/P2PDataStoreDisconnectTest.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3628/files#diff-6">p2p/src/test/java/bisq/network/p2p/storage/TestState.java</a>
    (30)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3628/files#diff-7">p2p/src/test/java/bisq/network/p2p/storage/mocks/ProtectedStoragePayloadStub.java</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/3628.patch'>https://github.com/bisq-network/bisq/pull/3628.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/3628.diff'>https://github.com/bisq-network/bisq/pull/3628.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3628?email_source=notifications&email_token=AJFFTNSUY6GSM6QNA2LT6MTQULOVPA5CNFSM4JOYM7J2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2D6IPA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQLAJO5BMVG4TW3RKDQULOVPANCNFSM4JOYM7JQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUVP2THTLOJ62IZQLTQULOVPA5CNFSM4JOYM7J2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2D6IPA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3628?email_source=notifications\u0026email_token=AJFFTNSUY6GSM6QNA2LT6MTQULOVPA5CNFSM4JOYM7J2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2D6IPA",
"url": "https://github.com/bisq-network/bisq/pull/3628?email_source=notifications\u0026email_token=AJFFTNSUY6GSM6QNA2LT6MTQULOVPA5CNFSM4JOYM7J2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2D6IPA",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>