<p><b>@freimair</b> approved this pull request.</p>
<p>utAck</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3583#discussion_r347233382">p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java</a>:</p>
<pre style='color:#555'>> - boolean result = storedData.getOwnerPubKey() != null && storedData.getOwnerPubKey().equals(ownerPubKey);
- if (!result)
- log.warn("New data entry does not match our stored data. storedData.ownerPubKey=" +
- (storedData.getOwnerPubKey() != null ? storedData.getOwnerPubKey().toString() : "null") +
- ", ownerPubKey=" + ownerPubKey);
-
- return result;
- }
-
- private boolean checkIfStoredMailboxDataMatchesNewMailboxData(PublicKey receiversPubKey, ByteArray hashOfData) {
- ProtectedStorageEntry storedData = map.get(hashOfData);
- if (storedData instanceof ProtectedMailboxStorageEntry) {
- ProtectedMailboxStorageEntry entry = (ProtectedMailboxStorageEntry) storedData;
- // publicKey is not the same (stored: sender, new: receiver)
- boolean result = entry.getReceiversPubKey().equals(receiversPubKey)
- && get32ByteHashAsByteArray(entry.getProtectedStoragePayload()).equals(hashOfData);
</pre>
<p>ah yes, thanks for sharing. Missed that one, although it is fairly obvious now.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3583?email_source=notifications&email_token=AJFFTNXB5BTKRVDWZDYOYWDQUJVMBA5CNFSM4JLCP7CKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL3HJ3A#pullrequestreview-318141676">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVSCCIJ5UQO22OE6OLQUJVMBANCNFSM4JLCP7CA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXNXPAKWWRAHWP6HALQUJVMBA5CNFSM4JLCP7CKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL3HJ3A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3583?email_source=notifications\u0026email_token=AJFFTNXB5BTKRVDWZDYOYWDQUJVMBA5CNFSM4JLCP7CKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL3HJ3A#pullrequestreview-318141676",
"url": "https://github.com/bisq-network/bisq/pull/3583?email_source=notifications\u0026email_token=AJFFTNXB5BTKRVDWZDYOYWDQUJVMBA5CNFSM4JLCP7CKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL3HJ3A#pullrequestreview-318141676",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>