<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=170962" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a> I see a few places where business logic is triggered directly in a window, for example:</p>
<ul>
<li><a href="https://github.com/bisq-network/bisq/blob/df6812a4c958553cfaf4587bf814de9d11be1a87/desktop/src/main/java/bisq/desktop/main/overlays/windows/SignPaymentAccountsWindow.java#L283">SignPaymentAccountsWindow</a></li>
<li><a href="https://github.com/bisq-network/bisq/blob/df6812a4c958553cfaf4587bf814de9d11be1a87/desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java#L645">DisputeSummaryWindow</a></li>
</ul>
<p>And a few candidates for similar refactoring:</p>
<ul>
<li><a href="https://github.com/bisq-network/bisq/blob/f3456f1920bb115a06ece23abdc3136449894895/desktop/src/main/java/bisq/desktop/main/account/register/AgentRegistrationView.java#L124">UnlockDisputeAgentRegistrationWindow</a></li>
<li><a href="https://github.com/bisq-network/bisq/blob/e0de9982e2e83713f65e36085e8fc09a24fe9078/desktop/src/main/java/bisq/desktop/main/overlays/editor/PeerInfoWithTagEditor.java#L250">SendPrivateNotificationWindow here</a> and <a href="https://github.com/bisq-network/bisq/blob/e0de9982e2e83713f65e36085e8fc09a24fe9078/desktop/src/main/java/bisq/desktop/main/overlays/editor/PeerInfoWithTagEditor.java#L250">here</a></li>
</ul>
<p>I think creating unnatural interfaces just to be able to pass single (always same) function from parent is overkill - it only increase complexity with no benefit.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3617?email_source=notifications&email_token=AJFFTNWP7MCTUM24NFUQCLTQUPCSHA5CNFSM4JN5WZF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEENZ6MA#issuecomment-555458352">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTRXR7XBKQHTI44FMTQUPCSHANCNFSM4JN5WZFQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUHOW3GHYE2MIYBLALQUPCSHA5CNFSM4JN5WZF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEENZ6MA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3617?email_source=notifications\u0026email_token=AJFFTNWP7MCTUM24NFUQCLTQUPCSHA5CNFSM4JN5WZF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEENZ6MA#issuecomment-555458352",
"url": "https://github.com/bisq-network/bisq/pull/3617?email_source=notifications\u0026email_token=AJFFTNWP7MCTUM24NFUQCLTQUPCSHA5CNFSM4JN5WZF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEENZ6MA#issuecomment-555458352",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>