<p><b>@blabno</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3586#discussion_r347876359">desktop/src/main/java/bisq/desktop/main/account/content/altcoinaccounts/AltCoinAccountsDataModel.java</a>:</p>
<pre style='color:#555'>> }
public boolean onDeleteAccount(PaymentAccount paymentAccount) {
- boolean isPaymentAccountUsed = openOfferManager.getObservableList().stream()
- .filter(o -> o.getOffer().getMakerPaymentAccountId().equals(paymentAccount.getId()))
- .findAny()
- .isPresent();
- isPaymentAccountUsed = isPaymentAccountUsed || tradeManager.getTradableList().stream()
- .filter(t -> t.getOffer().getMakerPaymentAccountId().equals(paymentAccount.getId()) ||
- paymentAccount.getId().equals(t.getTakerPaymentAccountId()))
- .findAny()
- .isPresent();
- if (!isPaymentAccountUsed)
- user.removePaymentAccount(paymentAccount);
- return isPaymentAccountUsed;
+ try {
+ paymentAccountManager.removePaymentAccount(paymentAccount.getId());
</pre>
<blockquote>
<p>We do not use ids as params for lookup if the object is available anyway.<br>
That's cool for desktop app, but as soon as you get any kind of API you will have to reference stuff by id.</p>
</blockquote>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3586?email_source=notifications&email_token=AJFFTNWZE3SKJIJD2WDLZSDQUPGJLA5CNFSM4JLIFYS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMBSD4I#discussion_r347876359">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWR6QOPROHHKIZGLL3QUPGJLANCNFSM4JLIFYSQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUVZ7AVZZBW4JZRX7LQUPGJLA5CNFSM4JLIFYS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMBSD4I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3586?email_source=notifications\u0026email_token=AJFFTNWZE3SKJIJD2WDLZSDQUPGJLA5CNFSM4JLIFYS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMBSD4I#discussion_r347876359",
"url": "https://github.com/bisq-network/bisq/pull/3586?email_source=notifications\u0026email_token=AJFFTNWZE3SKJIJD2WDLZSDQUPGJLA5CNFSM4JLIFYS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMBSD4I#discussion_r347876359",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>