<p><b>@julianknutsen</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3665#discussion_r349833115">p2p/src/test/java/bisq/network/p2p/storage/P2PDataStorageRemoveExpiredTest.java</a>:</p>
<pre style='color:#555'>> @@ -188,15 +188,5 @@ public void removeExpiredEntries_PurgeSeqNrMap() throws CryptoException, NoSuchA
         SavedTestState beforeState = this.testState.saveTestState(purgedProtectedStorageEntry);
         this.testState.mockedStorage.removeExpiredEntries();
         this.testState.verifyProtectedStorageRemove(beforeState, expectedRemoves, true, true, false, false, false);
-
</pre>
<p>This test was testing too much when just calling verifyProtectedStorageRemove() gives us what we want.</p>
<p>But, the failure did point out that we add expirable ProtectedStorageEntrys and then immediately expire them in the next expire cycle. I'll put this on my backlog to fix it. Not super urgent.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3665?email_source=notifications&email_token=AJFFTNV4ORJOS6JHZRY6X2LQVBTERA5CNFSM4JQXBSB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMXTUKA#pullrequestreview-321862184">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQTCEZLB2BMW2LUFWDQVBTERANCNFSM4JQXBSBQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNW5NLM4VI34JYMF2UDQVBTERA5CNFSM4JQXBSB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMXTUKA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3665?email_source=notifications\u0026email_token=AJFFTNV4ORJOS6JHZRY6X2LQVBTERA5CNFSM4JQXBSB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMXTUKA#pullrequestreview-321862184",
"url": "https://github.com/bisq-network/bisq/pull/3665?email_source=notifications\u0026email_token=AJFFTNV4ORJOS6JHZRY6X2LQVBTERA5CNFSM4JQXBSB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMXTUKA#pullrequestreview-321862184",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>