<p><b>@cbeams</b> commented on this pull request.</p>

<p>utACK assuming a valid answer to my comment.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3661#discussion_r349777404">desktop/src/main/java/bisq/desktop/main/support/dispute/agent/DisputeAgentView.java</a>:</p>
<pre style='color:#555'>> @@ -54,7 +50,7 @@ public DisputeAgentView(DisputeManager<? extends DisputeList<? extends DisputeLi
                             ContractWindow contractWindow,
                             TradeDetailsWindow tradeDetailsWindow,
                             AccountAgeWitnessService accountAgeWitnessService,
-                            @Named(AppOptionKeys.USE_DEV_PRIVILEGE_KEYS) boolean useDevPrivilegeKeys) {
</pre>
<p>It's not obvious to me why injection of this value would still work without the explicit annotation. The value of <code>AppOptionKeys.USE_DEV_PRIVILEGE_KEYS</code> is in fact "useDevPrivilegeKeys", spelled exactly the same as the <code>useDevPrivilegeKeys</code> parameter, so in theory Guice could introspect and do the injection based on that, but this information is not inspectable at runtime unless the <code>-parameters</code> option has been passed to javac to keep the parameter symbol table available (and our build does not do this). What am I missing?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3661?email_source=notifications&email_token=AJFFTNRZMNTVQGUSWBNPCMDQVA5B3A5CNFSM4JQRCGQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMXBIBA#pullrequestreview-321786884">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXL7DFXWILJC7T5UATQVA5B3ANCNFSM4JQRCGQA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNR6YR3MDCQID4FLDW3QVA5B3A5CNFSM4JQRCGQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMXBIBA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3661?email_source=notifications\u0026email_token=AJFFTNRZMNTVQGUSWBNPCMDQVA5B3A5CNFSM4JQRCGQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMXBIBA#pullrequestreview-321786884",
"url": "https://github.com/bisq-network/bisq/pull/3661?email_source=notifications\u0026email_token=AJFFTNRZMNTVQGUSWBNPCMDQVA5B3A5CNFSM4JQRCGQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMXBIBA#pullrequestreview-321786884",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>