<p><b>@ripcurlx</b> requested changes on this pull request.</p>
<p>NACK - please see my comments</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3658#discussion_r349506970">desktop/src/main/java/bisq/desktop/main/support/dispute/DisputeView.java</a>:</p>
<pre style='color:#555'>> @@ -139,7 +142,7 @@
public DisputeView(DisputeManager<? extends DisputeList<? extends DisputeList>> disputeManager,
KeyRing keyRing,
TradeManager tradeManager,
- CoinFormatter formatter,
+ @Named(FormattingUtils.BTC_FORMATTER_KEY) CoinFormatter formatter,
</pre>
<p>I think here it is not necessary as mentioned by <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/lusarz/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/lusarz">@lusarz</a>. At least it didn't crash for me here.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3658#discussion_r349507291">desktop/src/main/java/bisq/desktop/main/support/dispute/agent/DisputeAgentView.java</a>:</p>
<pre style='color:#555'>> @@ -48,7 +49,7 @@
public DisputeAgentView(DisputeManager<? extends DisputeList<? extends DisputeList>> disputeManager,
KeyRing keyRing,
TradeManager tradeManager,
- CoinFormatter formatter,
+ @Named(FormattingUtils.BTC_FORMATTER_KEY) CoinFormatter formatter,
</pre>
<p>I think here it is not necessary.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3658#discussion_r349507426">desktop/src/main/java/bisq/desktop/main/support/dispute/client/DisputeClientView.java</a>:</p>
<pre style='color:#555'>> @FxmlView
public abstract class DisputeClientView extends DisputeView {
public DisputeClientView(DisputeManager<? extends DisputeList<? extends DisputeList>> DisputeManager,
KeyRing keyRing,
TradeManager tradeManager,
- CoinFormatter formatter,
+ @Named(FormattingUtils.BTC_FORMATTER_KEY) CoinFormatter formatter,
</pre>
<p>I think here it is not necessary.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3658?email_source=notifications&email_token=AJFFTNTAQPA3IIIDGM3OA3TQU6SLFA5CNFSM4JQIXJT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMUJWCA#pullrequestreview-321428232">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVNCMPF43ONYSNVQ4TQU6SLFANCNFSM4JQIXJTQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTCHTEXTSW2KVOI5N3QU6SLFA5CNFSM4JQIXJT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMUJWCA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3658?email_source=notifications\u0026email_token=AJFFTNTAQPA3IIIDGM3OA3TQU6SLFA5CNFSM4JQIXJT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMUJWCA#pullrequestreview-321428232",
"url": "https://github.com/bisq-network/bisq/pull/3658?email_source=notifications\u0026email_token=AJFFTNTAQPA3IIIDGM3OA3TQU6SLFA5CNFSM4JQIXJT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMUJWCA#pullrequestreview-321428232",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>