<p>New commits <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/931c1f47b4ff40ccf54137d60a1d1dc6574cd822/hovercard" href="https://github.com/bisq-network/bisq/commit/931c1f47b4ff40ccf54137d60a1d1dc6574cd822"><tt>931c1f4</tt></a></p>
<p>In the event that we receive an out of order RemoveData or RemoveMailboxData message, relay it to the P2P network. This should help with the propagation of these messages.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/3664'>https://github.com/bisq-network/bisq/pull/3664</a></p>
<h4>Commit Summary</h4>
<ul>
<li>[PR COMMENTS] Make maxSequenceNumberBeforePurge final</li>
<li>[TESTS] Clean up 'Analyze Code' warnings</li>
<li>[REFACTOR] HashMapListener::onAdded/onRemoved</li>
<li>[REFACTOR] removeFromMapAndDataStore can operate on Collections</li>
<li>Change removeFromMapAndDataStore to signal listeners at the end in a batch</li>
<li>Update removeExpiredEntries to remove all items in a batch</li>
<li>ProposalService::onProtectedDataRemoved signals listeners once on batch removes</li>
<li>Remove HashmapChangedListener::onBatch operations</li>
<li>[TESTS] Regression test for #3629</li>
<li>[BUGFIX] Reconstruct HashMap using 32-byte key</li>
<li>[BUGFIX] Use 32-byte key in requestData path</li>
<li>[DEAD CODE] Remove getProtectedDataStoreMap</li>
<li>[TESTS] Allow tests to validate SequenceNumberMap write separately</li>
<li>Implement remove-before-add message sequence behavior</li>
<li>[TESTS] Allow remove() verification to be more flexible</li>
<li>Broadcast remove-before-add messages to P2P network</li>
<li>[TESTS] Clean up remove verification helpers</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-0">core/src/main/java/bisq/core/alert/AlertManager.java</a>
(32)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-1">core/src/main/java/bisq/core/dao/governance/proposal/ProposalListPresentation.java</a>
(49)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-2">core/src/main/java/bisq/core/dao/governance/proposal/ProposalService.java</a>
(65)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-3">core/src/main/java/bisq/core/dao/governance/proposal/storage/temp/TempProposalStore.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-4">core/src/main/java/bisq/core/filter/FilterManager.java</a>
(31)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-5">core/src/main/java/bisq/core/offer/OfferBookService.java</a>
(37)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-6">core/src/main/java/bisq/core/support/dispute/agent/DisputeAgentManager.java</a>
(23)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-7">core/src/test/java/bisq/core/dao/governance/proposal/ProposalServiceP2PDataStorageListenerTest.java</a>
(127)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-8">p2p/src/main/java/bisq/network/p2p/P2PModule.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-9">p2p/src/main/java/bisq/network/p2p/P2PService.java</a>
(13)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-10">p2p/src/main/java/bisq/network/p2p/peers/getdata/RequestDataHandler.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-11">p2p/src/main/java/bisq/network/p2p/storage/HashMapChangedListener.java</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-12">p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java</a>
(115)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-13">p2p/src/test/java/bisq/network/p2p/storage/P2PDataStorageClientAPITest.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-14">p2p/src/test/java/bisq/network/p2p/storage/P2PDataStoragePersistableNetworkPayloadTest.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-15">p2p/src/test/java/bisq/network/p2p/storage/P2PDataStorageProtectedStorageEntryTest.java</a>
(80)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-16">p2p/src/test/java/bisq/network/p2p/storage/P2PDataStorageRemoveExpiredTest.java</a>
(24)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-17">p2p/src/test/java/bisq/network/p2p/storage/P2PDataStoreDisconnectTest.java</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-18">p2p/src/test/java/bisq/network/p2p/storage/TestState.java</a>
(191)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/3664/files#diff-19">p2p/src/test/java/bisq/network/p2p/storage/mocks/ProtectedStoragePayloadStub.java</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/3664.patch'>https://github.com/bisq-network/bisq/pull/3664.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/3664.diff'>https://github.com/bisq-network/bisq/pull/3664.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3664?email_source=notifications&email_token=AJFFTNWUIWNTCWZJVSIKJE3QVA2JVA5CNFSM4JQVJBIKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3PIWEQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWGYGSHMJ3IVVWLSWLQVA2JVANCNFSM4JQVJBIA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNSUY7D7IJCMLI32UMLQVA2JVA5CNFSM4JQVJBIKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3PIWEQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3664?email_source=notifications\u0026email_token=AJFFTNWUIWNTCWZJVSIKJE3QVA2JVA5CNFSM4JQVJBIKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3PIWEQ",
"url": "https://github.com/bisq-network/bisq/pull/3664?email_source=notifications\u0026email_token=AJFFTNWUIWNTCWZJVSIKJE3QVA2JVA5CNFSM4JQVJBIKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3PIWEQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>