<p><b>@julianknutsen</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/3667#discussion_r349882220">p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java</a>:</p>
<pre style='color:#555'>> @@ -315,9 +308,7 @@ private boolean shouldTransmitPayloadToPeer(Capabilities peerCapabilities, Netwo
                 doAdd = true;
             }
             if (doAdd) {
-                boolean notContained = lookupSet.add(protectedStoragePayload.hashCode());
</pre>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/chimp1984/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/chimp1984">@chimp1984</a> I could use your prior knowledge for the behavior. Do you know of any cases where we intentionally want/expect the payload hash and the hashCode to be different?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3667?email_source=notifications&email_token=AJFFTNVEAG3XK4AEHBGI6Y3QVFUJ3A5CNFSM4JQ3FUZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMYCCGA#pullrequestreview-321921304">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTJOXMG2UT3ELHYZGLQVFUJ3ANCNFSM4JQ3FUZA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNSBBB7YH7AX2BQXLMDQVFUJ3A5CNFSM4JQ3FUZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMYCCGA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3667?email_source=notifications\u0026email_token=AJFFTNVEAG3XK4AEHBGI6Y3QVFUJ3A5CNFSM4JQ3FUZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMYCCGA#pullrequestreview-321921304",
"url": "https://github.com/bisq-network/bisq/pull/3667?email_source=notifications\u0026email_token=AJFFTNVEAG3XK4AEHBGI6Y3QVFUJ3A5CNFSM4JQ3FUZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMYCCGA#pullrequestreview-321921304",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>