<p>Use stricter criteria when deciding which of the taker's accounts (if any) are valid for a given offer. Specifically, prevent National Bank accounts from being used to take Same / Specific Bank(s) offers, so the three payment method types can never being mixed.</p>
<p>This prevents an error on the trading peer when the trade starts, due to enforcement of equal maker & taker payment method IDs (except for SEPA) in the Contract payload constructor.</p>
<p>This partially addresses <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="521831272" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/3602" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/3602/hovercard" href="https://github.com/bisq-network/bisq/issues/3602">#3602</a>, where the erroneous peer response caused the taker to be presented with a confusing timeout, after they managed to take a <em>SAME_BANK</em> offer using their <em>NATIONAL_BANK</em> account. With this change, the taker would be directed to create a separate <em>SAME_BANK</em> account if they don't have one already (which would then be automatically selected).</p>
<p>(Later, it might be worthwhile to make a more substantial change to allow National, Same or Specific Bank account types to be mixed under certain circumstances when trading, but that could be complicated by the peer running an older version.)</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/3673'>https://github.com/bisq-network/bisq/pull/3673</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Use strict stubbing for ReceiptValidatorTest to avoid confusion</li>
  <li>Prevent taking of offers with unequal bank account types</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3673/files#diff-0">core/src/main/java/bisq/core/payment/ReceiptValidator.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3673/files#diff-1">core/src/test/java/bisq/core/payment/ReceiptValidatorTest.java</a>
    (82)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/3673.patch'>https://github.com/bisq-network/bisq/pull/3673.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/3673.diff'>https://github.com/bisq-network/bisq/pull/3673.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3673?email_source=notifications&email_token=AJFFTNSIMYKWBJD47US4XKTQVIH6PA5CNFSM4JQ5QDEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3TLHEQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQG7ELIMWPFLAPT3ZLQVIH6PANCNFSM4JQ5QDEA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTG7EQUJCFXXZ7M2X3QVIH6PA5CNFSM4JQ5QDEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3TLHEQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3673?email_source=notifications\u0026email_token=AJFFTNSIMYKWBJD47US4XKTQVIH6PA5CNFSM4JQ5QDEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3TLHEQ",
"url": "https://github.com/bisq-network/bisq/pull/3673?email_source=notifications\u0026email_token=AJFFTNSIMYKWBJD47US4XKTQVIH6PA5CNFSM4JQ5QDEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3TLHEQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>