<p>Prevent the 'arrow' of a message bubble from being sporadically anchored to the wrong side - appearing on the left instead of the right hand side of the bubble. This is due to the same <code>ListCell</code> object being reused by JavaFX for different bubbles as the user scrolls up and down the chat pane, which requires that the anchors of each arrow be properly cleared between <code>ListCell.updateItem(..)</code> calls.</p>
<p>To this end, move the block of <code>AnchorPane.clearConstraints(..)</code> calls to the beginning of the <code>updateItem(..) method</code>, as the apparent assumption that <code>updateItem(item, empty = true)</code> will always be called to clear the given <code>ListCell</code> before reusing it as a new bubble turns out to be wrong.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/3680'>https://github.com/bisq-network/bisq/pull/3680</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix #3662: Malformed trade chat & dispute speech bubbles</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/3680/files#diff-0">desktop/src/main/java/bisq/desktop/main/shared/ChatView.java</a>
    (23)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/3680.patch'>https://github.com/bisq-network/bisq/pull/3680.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/3680.diff'>https://github.com/bisq-network/bisq/pull/3680.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3680?email_source=notifications&email_token=AJFFTNTRQ5XGRYBXUSVRJNLQVM7WFA5CNFSM4JRCX63KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3V3TMQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVWAPTNBJX7HNA7CQTQVM7WFANCNFSM4JRCX63A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUG4NA6GE4XN4F4THTQVM7WFA5CNFSM4JRCX63KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3V3TMQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3680?email_source=notifications\u0026email_token=AJFFTNTRQ5XGRYBXUSVRJNLQVM7WFA5CNFSM4JRCX63KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3V3TMQ",
"url": "https://github.com/bisq-network/bisq/pull/3680?email_source=notifications\u0026email_token=AJFFTNTRQ5XGRYBXUSVRJNLQVM7WFA5CNFSM4JRCX63KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3V3TMQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>