<p><b>@m52go</b> requested changes on this pull request.</p>
<p>Thanks for this—seems like low-hanging fruit to improve site traffic and perhaps downloads.</p>
<p>Some of my comments might be subjective, but I would say that such unclear things are better left unspecified/omitted.</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/290#discussion_r350342104">_layouts/default.html</a>:</p>
<pre style='color:#555'>> @@ -63,6 +63,60 @@
<script defer src="/js/bootstrap.min.js"></script>
<script defer src="/js/scripts.js"></script>
+ <!-- Schema.org JSON-LD Markup for Search Engine Optimization -->
+ <script type='application/ld+json'>
+ {
+ "@context": "https://schema.org/",
+ "@type": "SoftwareApplication",
+ "applicationCategory": "FinanceApplication",
+ "name": "Bisq",
+ "image": "https://bisq.network/images/bisq-logo.svg",
+ "availableOnDevice": [
</pre>
<p>Bisq isn't available on mobile devices right now...just desktop. There is a notifications app, but I don't think it's right to classify that as Bisq "being available" on those platforms.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/290#discussion_r350342779">_layouts/default.html</a>:</p>
<pre style='color:#555'>> @@ -63,6 +63,60 @@
<script defer src="/js/bootstrap.min.js"></script>
<script defer src="/js/scripts.js"></script>
+ <!-- Schema.org JSON-LD Markup for Search Engine Optimization -->
+ <script type='application/ld+json'>
+ {
+ "@context": "https://schema.org/",
+ "@type": "SoftwareApplication",
+ "applicationCategory": "FinanceApplication",
+ "name": "Bisq",
+ "image": "https://bisq.network/images/bisq-logo.svg",
+ "availableOnDevice": [
+ "Desktop",
+ "Smartphone",
+ "Tablet"
+ ],
+ "author": {
+ "@type": "Organization",
</pre>
<p>The Bisq DAO isn't really an organization...it's just a loose group of individuals who contribute to the software. I would prefer to see this <code>author</code> attribute removed, even if it comes at the expense of some clicks, since it's a legal grey area.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/290#discussion_r350342821">_layouts/default.html</a>:</p>
<pre style='color:#555'>> + "name": "Bisq Decentralized Autonomous Organization",
+ "sameAs": [
+ "https://github.com/bisq-network",
+ "https://twitter.com/bisq_network",
+ "https://www.youtube.com/c/bisq-network",
+ "https://bisq.network/slack-invite",
+ "https://bisq.community/",
+ "https://lists.bisq.network/listinfo/bisq-contrib",
+ "https://webchat.freenode.net/?channels=bisq",
+ "https://www.reddit.com/r/bisq",
+ "https://keybase.io/team/bisq"
+ ]
+ },
+ "downloadUrl": "https://bisq.network/downloads/",
+ "fileSize": "180MB",
+ "operatingSystem": [
</pre>
<p>See above comment—iOS and Android should be removed.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/290#discussion_r350342871">_layouts/default.html</a>:</p>
<pre style='color:#555'>> + "https://keybase.io/team/bisq"
+ ]
+ },
+ "downloadUrl": "https://bisq.network/downloads/",
+ "fileSize": "180MB",
+ "operatingSystem": [
+ "Windows",
+ "Linux",
+ "OSX",
+ "iOs",
+ "Android"
+ ],
+ "releaseNotes": "https://github.com/bisq-network/bisq/releases",
+ "screenshot": "https://bisq.network/images/bisq_screen0.svg",
+ "softwareVersion": "{{ site.client_version }}",
+ "aggregateRating": {
</pre>
<p>Where's this rating data from? If it's a placeholder/dummy data then I think it's better to omit it.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/290#discussion_r350342923">_layouts/default.html</a>:</p>
<pre style='color:#555'>> + "operatingSystem": [
+ "Windows",
+ "Linux",
+ "OSX",
+ "iOs",
+ "Android"
+ ],
+ "releaseNotes": "https://github.com/bisq-network/bisq/releases",
+ "screenshot": "https://bisq.network/images/bisq_screen0.svg",
+ "softwareVersion": "{{ site.client_version }}",
+ "aggregateRating": {
+ "@type": "AggregateRating",
+ "ratingValue": "5",
+ "ratingCount": "20"
+ },
+ "offers": {
</pre>
<p>Bisq itself doesn't exchange bitcoin, so I think it's better to omit this too.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-website/pull/290?email_source=notifications&email_token=AJFFTNSYGXKB4KWCTDZGZF3QVQI43A5CNFSM4JQBKNH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCM4KG3Y#pullrequestreview-322478959">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQTRUBY3UFHZIZVMOTQVQI43ANCNFSM4JQBKNHQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTONCXFKYKO54MDY6TQVQI43A5CNFSM4JQBKNH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCM4KG3Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-website/pull/290?email_source=notifications\u0026email_token=AJFFTNSYGXKB4KWCTDZGZF3QVQI43A5CNFSM4JQBKNH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCM4KG3Y#pullrequestreview-322478959",
"url": "https://github.com/bisq-network/bisq-website/pull/290?email_source=notifications\u0026email_token=AJFFTNSYGXKB4KWCTDZGZF3QVQI43A5CNFSM4JQBKNH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCM4KG3Y#pullrequestreview-322478959",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>